Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Update essential requirements #817

Merged
merged 4 commits into from
Mar 31, 2022
Merged

[Improve] Update essential requirements #817

merged 4 commits into from
Mar 31, 2022

Conversation

wangruohui
Copy link
Member

@wangruohui wangruohui commented Mar 24, 2022 •
edited
Loading

  • remove yapf and skimage
  • add numpy and pillow
  • add torch and torchvision

@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #817 (d92ca0f) into master (e2d2b15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files         219      219           
  Lines       12285    12285           
  Branches     1984     1984           
=======================================
  Hits        10206    10206           
  Misses       1768     1768           
  Partials      311      311
Flag Coverage Δ
unittests 83.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d2b15...d92ca0f. Read the comment docs.

Yshuo-Li
Yshuo-Li reviewed Mar 25, 2022
View reviewed changes
requirements/runtime.txt
tensorboard
yapf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete these two lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this codebase no longer rely on scikit-image, I search skimage, and there is no code importing this, also CI passes.
yapf is only a code formatter, it is not a runtime dependency.

Further, I think we need to add numpy and pillow. They are now installed as a dependency of torchvison, but we'd better to add them in requirements explicitly. I will append them and rename this PR.

@wangruohui wangruohui changed the title Update mmcv-full>=1.3.13 to support DCN on CPU [Improve] Update essential requirements/runtime.txt Mar 26, 2022
@wangruohui wangruohui changed the title [Improve] Update essential requirements/runtime.txt [Improve] Update essential requirements Mar 26, 2022
@wangruohui wangruohui merged commit d943803 into master Mar 31, 2022
@wangruohui wangruohui deleted the wangruohui-patch-1 branch March 31, 2022 05:45
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@wangruohui
[Improve] Update essential requirements (open-mmlab#817)
a87d0c4 
* Update mmcv-full>=1.3.13 to support DCN on CPU

* remove skimage

* update

Co-authored-by: wangruohui <wangruohui@local>
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@wangruohui
[Improve] Update essential requirements (open-mmlab#817)
ad5e841 
* Update mmcv-full>=1.3.13 to support DCN on CPU

* remove skimage

* update

Co-authored-by: wangruohui <wangruohui@local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yshuo-Li Yshuo-Li Yshuo-Li left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wangruohui @Yshuo-Li