Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Add --cfg-options in train/test scripts #826

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Mar 31, 2022

https://github.com/open-mmlab/mmdetection/blob/3e2693151add9b5d6db99b944da020cba837266b/tools/train.py#L72

Sometimes we want to use a custom runtime configuration for a given configuration file.
This feature is already supported in other mm-frameworks, so I added it.

@mm-assistant mm-assistant bot added the size/XS label Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #826 (6e5110c) into master (df8bab1) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   83.08%   83.17%   +0.09%     
==========================================
  Files         219      220       +1     
  Lines       12354    12441      +87     
  Branches     2000     2012      +12     
==========================================
+ Hits        10264    10348      +84     
- Misses       1774     1775       +1     
- Partials      316      318       +2     
Flag Coverage Δ
unittests 83.14% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️
mmedit/models/backbones/vfi_backbones/__init__.py 100.00% <0.00%> (ø)
...edit/models/backbones/vfi_backbones/tof_vfi_net.py 98.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8bab1...6e5110c. Read the comment docs.

@nijkah nijkah changed the title add cfg-options for tools scripts add cfg-options in train/test scripts Mar 31, 2022
@wangruohui wangruohui mentioned this pull request Apr 1, 2022
@wangruohui
Copy link
Member

Hello, thanks again for your contribution.
Would you please also help to mention this feature in the documentation?

Don't worry, if you do not speak Chinese we will fix the last two.

@wangruohui
Copy link
Member

Fix #569

@wangruohui wangruohui self-requested a review April 1, 2022 06:22
@wangruohui wangruohui added this to the v0.15.0 milestone Apr 1, 2022
@nijkah
Copy link
Contributor Author

nijkah commented Apr 3, 2022

I added minimal explanation to docs/en/getting_started.md and docs/en/quick_run.md.
@wangruohui Can I ask you to check it?

@wangruohui wangruohui changed the title add cfg-options in train/test scripts [Improve] Add --cfg-options in train/test scripts Apr 6, 2022
@wangruohui
Copy link
Member

I have added lines in Chinese docs. We can merge this after all CI passes.

@wangruohui wangruohui merged commit ee1b232 into open-mmlab:master Apr 6, 2022
biubiubiiu added a commit to biubiubiiu/derain-toolbox that referenced this pull request Apr 9, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* add cfg-options for tools scripts

* add a description about --cfg-options

* Add cfg-option in chinese docs

Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* add cfg-options for tools scripts

* add a description about --cfg-options

* Add cfg-option in chinese docs

Co-authored-by: wangruohui <12756472+wangruohui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants