Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support use_cache and backend in LoadImageFromFileList #857

Merged
merged 2 commits into from
May 12, 2022

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #857 (229d7f9) into master (a023cdf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   83.10%   83.18%   +0.08%     
==========================================
  Files         220      221       +1     
  Lines       12452    12491      +39     
  Branches     2017     2027      +10     
==========================================
+ Hits        10348    10391      +43     
+ Misses       1786     1785       -1     
+ Partials      318      315       -3     
Flag Coverage Δ
unittests 83.14% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/loading.py 97.39% <100.00%> (+1.37%) ⬆️
...edit/models/backbones/vfi_backbones/tof_vfi_net.py 94.18% <0.00%> (-4.66%) ⬇️
mmedit/core/evaluation/eval_hooks.py 61.53% <0.00%> (-0.63%) ⬇️
mmedit/datasets/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/vfi_vimeo90k_7frames_dataset.py 100.00% <0.00%> (ø)
mmedit/datasets/sr_folder_video_dataset.py 98.63% <0.00%> (+0.01%) ⬆️
mmedit/datasets/pipelines/augmentation.py 98.89% <0.00%> (+0.39%) ⬆️
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️
mmedit/datasets/pipelines/formating.py 99.05% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a023cdf...229d7f9. Read the comment docs.

@wangruohui
Copy link
Member

Is this used for speeding up loading or decoding?

@Yshuo-Li
Copy link
Collaborator Author

Is this used for speeding up loading or decoding?

Yes, it is.

Beside, LoadImageFromFileList should support pillow backend.

@Yshuo-Li Yshuo-Li requested a review from wangruohui May 9, 2022 07:02
@wangruohui wangruohui merged commit 3351cdc into open-mmlab:master May 12, 2022
wangruohui pushed a commit to wangruohui/mmediting that referenced this pull request Jul 7, 2022
…pen-mmlab#857)

* [Feature] Support use_cache and backend in LoadImageFromFileList

* Update
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…pen-mmlab#857)

* [Feature] Support use_cache and backend in LoadImageFromFileList

* Update
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
…pen-mmlab#857)

* [Feature] Support use_cache and backend in LoadImageFromFileList

* Update
biubiubiiu added a commit to biubiubiiu/derain-toolbox that referenced this pull request Jul 15, 2022
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 16, 2022
…pen-mmlab#857)

* [Feature] Support use_cache and backend in LoadImageFromFileList

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants