[Feature] Support FLAVR Net #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangruohui
reviewed
Apr 27, 2022
|
|
||
| # Batch mean normalization works slightly better than global mean | ||
| # normalization, Refer to https://github.com/myungsub/CAIN | ||
| mean_ = images.mean( |
There was a problem hiding this comment.
image.mean(dim=(2,3,4), True)
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 83.12% 83.25% +0.13%
==========================================
Files 220 222 +2
Lines 12453 12648 +195
Branches 2017 2049 +32
==========================================
+ Hits 10351 10530 +179
- Misses 1785 1794 +9
- Partials 317 324 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wangruohui
reviewed
Apr 27, 2022
wangruohui
reviewed
Apr 27, 2022
wangruohui
previously approved these changes
Apr 30, 2022
| dx_out = self.decoder(xs) | ||
|
|
||
| out = self.feature_fuse(dx_out) | ||
| out = self.conv_last(out) |
There was a problem hiding this comment.
I meant we'd better add some comments here to indicate out's shape.
|
|
||
| # prepare data | ||
| inputs = torch.rand(1, 4, 3, 256, 248) | ||
| target = torch.rand(1, 3, 256, 248) |
|
|
||
| UpConv3d(4, 4, 1, 1, 1) | ||
| conv3d = UpConv3d(4, 4, 1, 1, 1, up_mode='trilinear', batchnorm=True) | ||
| conv3d(inputs) |
There was a problem hiding this comment.
Any assertion for line 42-46?
wangruohui
approved these changes
May 8, 2022
wangruohui
pushed a commit
to wangruohui/mmediting
that referenced
this pull request
Jul 7, 2022
* [Feature] Support FLAVR Net * Update * Update * Update * Update * Update
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* [Feature] Support FLAVR Net * Update * Update * Update * Update * Update
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* [Feature] Support FLAVR Net * Update * Update * Update * Update * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.