Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Limit the number of logged params for MLFlow Visbackend #1156

Closed
KickCellarDoor opened this issue May 19, 2023 · 1 comment · Fixed by #1159
Closed

[Feature] Limit the number of logged params for MLFlow Visbackend #1156

KickCellarDoor opened this issue May 19, 2023 · 1 comment · Fixed by #1159

Comments

@KickCellarDoor
Copy link
Contributor

What is the feature?

MLFlow has a 500 limit for logged parameters, while for most of the openmmlab projects, the config file contains more than 500 parameters. I think we should add an option to choose which parameters to log to the MLFlow tracking server.

@force_init_env
def add_config(self, config: Config, **kwargs) -> None:
    """Record the config to mlflow.

    Args:
        config (Config): The Config object
    """
    self.cfg = config
    log_keys = [''model"]
    log_cfg = dict()
    for k in log_keys:
        log_cfg[k] = config[k]
    self._mlflow.log_params(self._flatten(log_cfg))
    self._mlflow.log_text(self.cfg.pretty_text, 'config.py')

Something like this, but the log keys parameters should be passed through the vis_backend config.

Any other context?

No response

@zhouzaida
Copy link
Member

zhouzaida commented May 21, 2023

Hi @KickCellarDoor , thanks for your feedback. We can add a new parameter in

artifact_suffix: SUFFIX_TYPE = ('.json', '.log', '.py',
'yaml')):
and are you interesting in submitting a commit to support it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants