Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Flow1D Algorithm #255

Open
wants to merge 1 commit into
base: dev-1.x
Choose a base branch
from

Conversation

Zachary-66
Copy link
Collaborator

Motivation

Add Flow1D algorithm. This PR is based on #213 and the official code of Flow1D. Thanks for their excellent work!

Modification

1.configs/_base_/models/flow1d.py
2. configs/flow1d/flow1d_8xb2_100k_flyingchairs-368x496.py
3. mmflow/datasets/transforms/transforms.py (fix a bug)
4. mmflow/models/decoders/__init__.py
5. mmflow/models/decoders/flow1d_decoder.py
6. mmflow/models/flow_estimators/__init__.py
7. mmflow/models/flow_estimators/flow1d.py
8. mmflow/models/utils/__init__.py
9. mmflow/models/utils/attention1d.py
10. mmflow/models/utils/corr_lookup.py
11. mmflow/models/utils/correlation1d.py
12. tests/test_models/test_decoders/test_flow1d_decoder.py
13. tests/test_models/test_flow_estimators.py
14. tests/test_models/test_utils/test_corr_lookup.py

TODO

Reproduce the metrics of the original paper.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 73.03% // Head: 75.19% // Increases project coverage by +2.16% 🎉

Coverage data is based on head (1f5d98c) compared to base (712ffdb).
Patch coverage: 93.86% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #255      +/-   ##
===========================================
+ Coverage    73.03%   75.19%   +2.16%     
===========================================
  Files           96      100       +4     
  Lines         4950     5160     +210     
  Branches       623      640      +17     
===========================================
+ Hits          3615     3880     +265     
+ Misses        1220     1155      -65     
- Partials       115      125      +10     
Flag Coverage Δ
unittests 75.19% <93.86%> (+2.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/datasets/transforms/transforms.py 72.62% <0.00%> (ø)
mmflow/models/decoders/flow1d_decoder.py 90.00% <90.00%> (ø)
mmflow/models/utils/attention1d.py 95.74% <95.74%> (ø)
mmflow/models/decoders/__init__.py 100.00% <100.00%> (ø)
mmflow/models/flow_estimators/__init__.py 100.00% <100.00%> (ø)
mmflow/models/flow_estimators/flow1d.py 100.00% <100.00%> (ø)
mmflow/models/utils/__init__.py 100.00% <100.00%> (ø)
mmflow/models/utils/corr_lookup.py 98.80% <100.00%> (+0.93%) ⬆️
mmflow/models/utils/correlation1d.py 100.00% <100.00%> (ø)
mmflow/models/decoders/gma_decoder.py 97.97% <0.00%> (+2.02%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant