Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Installation does not provide clear examples that work on CPU #1687

Closed
nigelsim opened this issue Jan 19, 2023 · 1 comment 路 Fixed by #1608
Closed

[Docs] Installation does not provide clear examples that work on CPU #1687

nigelsim opened this issue Jan 19, 2023 · 1 comment 路 Fixed by #1608
Assignees

Comments

@nigelsim
Copy link

Branch

master branch https://mmocr.readthedocs.io/en/latest/

馃摎 The doc issue

By default, the mmocr/ocr.py script uses cuda as the device, as opposed to automatically detecting. All of the install and quick start docs suggest you run commands like python mmocr/ocr.py --det DB_r18 --recog CRNN demo/demo_text_ocr.jpg --show to test the system, but these do not work, and fail in an unexpected way that sends users off trying to fix they pyTorch installs.

The docs already show how to otherwise get the system running on a CPU. Could you provide CPU and CUDA examples for these test scripts, at least in the installation.

Suggest a potential alternative/fix

Run the following in MMOCR鈥檚 directory:

python mmocr/ocr.py --det DB_r18 --recog CRNN demo/demo_text_ocr.jpg --show

or, for CPU only

python mmocr/ocr.py --det DB_r18 --recog CRNN demo/demo_text_ocr.jpg --show --device cpu
@gaotongxiao
Copy link
Collaborator

Thanks for the feedback. We will release a new inference implementation that will automatically detect the best device to use. I guess we don't need to revise the docs at this moment.

@gaotongxiao gaotongxiao linked a pull request Feb 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants