Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly extra hwloc files in the repo #3940

Closed
artpol84 opened this issue Jul 20, 2017 · 2 comments
Closed

Possibly extra hwloc files in the repo #3940

artpol84 opened this issue Jul 20, 2017 · 2 comments
Assignees

Comments

@artpol84
Copy link
Contributor

@ggouaillardet when I ran autogen on master and did git diff I noticed:

$ git diff
diff --git a/opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in b/opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in
index f65a8be..5d3ec37 100644
--- a/opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in
+++ b/opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in
@@ -634,9 +634,6 @@
 /* Define to 1 if scotch is netlocscotch is enabled */
 #undef NETLOC_SCOTCH
 
-/* Define to 1 if your C compiler doesn't accept -c and -o together. */
-#undef NO_MINUS_C_MINUS_O
-
 /* Name of package */
 #undef PACKAGE

it seems to me that opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in shouldn't be in the repo. But it went there:

$ git log opal/mca/hwloc/hwloc2x/hwloc/include/private/autogen/config.h.in
commit 593e4ce63f22d32943de1915cd509261ccf20042
Author: Gilles Gouaillardet <gilles@rist.or.jp>
Date:   Mon Apr 10 10:12:59 2017 +0900

    hwloc: add hwloc2x
    
    internal hwloc 2x is used with --with-hwloc=future
    
    Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>

Can you have a look?

@rhc54
Copy link
Contributor

rhc54 commented Jul 20, 2017

I have it fixed - commit coming

@rhc54
Copy link
Contributor

rhc54 commented Jul 20, 2017

Fixed with 7d8d877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants