Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapModel] Introduce types attributes and "Union"-Type for layers #305

Open
mbeckem opened this issue Apr 11, 2024 · 1 comment
Open

[MapModel] Introduce types attributes and "Union"-Type for layers #305

mbeckem opened this issue Apr 11, 2024 · 1 comment

Comments

@mbeckem
Copy link
Contributor

mbeckem commented Apr 11, 2024

Currently layer in the layer model do not have a attribute that can be used to determine the type of a layer (e.g. SimpleLayer, WMSLayer, ...). It would be helpful to introduce an attribute on the layer that specifies its type.

Additionally, it would be helpful to introduce a union type for layers that allows Typescript narrowing. Currently all layer types depend on a type, which is used in cases where multiple layer types (kinds) are allowed. However, it is not possible to narrow the layer type.

@mbeckem
Copy link
Contributor Author

mbeckem commented Apr 11, 2024

Note: the resulting union(s) should become the "official" Layer / Sublayer type. The current one should be renamed into a "base type" instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant