Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting certValidityDuration #20

Open
eatwithforks opened this issue Jan 19, 2021 · 2 comments
Open

allow setting certValidityDuration #20

eatwithforks opened this issue Jan 19, 2021 · 2 comments

Comments

@eatwithforks
Copy link

having certs valid for 10 years seems sketchy and we want to test the rotation works by setting it to 5 minutes.

@ritazh
Copy link
Member

ritazh commented Jan 20, 2021

There was no particular reasons for why 10 years. I think we discussed this in the past where it can be made configurable.

@maxsmythe
Copy link
Contributor

From the G8r community meeting notes:

Changes required (in order)

  • Document the generation and rotation algorithms
  • Support keeping the old public key in the VWH config when rotating to also support the new public key
    • necessary to avoid downtime due to key rotation
  • Use 1 secret per webhook pod to store the public/private key pair
    • necessary to avoid updating the key pair for all webhook pods at the same time
  • Add validity duration flags and validity check lookahead time flags so users can control validity duration and the expected time at which certs will be rotated
  • Consider changing the default validity period after getting feedback from everyone on the risk/reward tradeoffs of different periods
  • TODO file issues for the above and continue to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants