Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mutation webhook benchmark tests #1082

Closed
maxsmythe opened this issue Jan 22, 2021 · 4 comments
Closed

Add mutation webhook benchmark tests #1082

maxsmythe opened this issue Jan 22, 2021 · 4 comments
Assignees
@willbeason
Labels
mutation

Comments

@maxsmythe
Copy link
Contributor

Following the same model as the policy benchmark tests:

https://github.com/open-policy-agent/gatekeeper/blob/master/pkg/webhook/policy_benchmark_test.go
@maxsmythe maxsmythe assigned maxsmythe and unassigned maxsmythe Jan 22, 2021
@maxsmythe maxsmythe added this to the Mutation milestone Jan 22, 2021
@sozercan sozercan removed this from the Mutation milestone Feb 17, 2021
@maxsmythe maxsmythe added this to the Mutation Beta milestone Apr 1, 2021
@willbeason
Copy link
Member

I'd be very happy to take this!

@willbeason
Copy link
Member

Actively working on, and already finding lots of improvements! In general it seems the Mutate methods can be sped up by ~10x with fairly straightforward changes.

#1439
#1441
#1442

@ritazh
Copy link
Member

ritazh commented Sep 1, 2021

Per community call, this is not a blocker for mutation beta.

@willbeason willbeason removed this from the Mutation Beta milestone Sep 9, 2021
@willbeason
Copy link
Member

Done since we've done the improvements now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willbeason willbeason

Labels
mutation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sozercan @ritazh @willbeason @maxsmythe