New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make this an ES module #38
Comments
💭 Would using some clever CDN like https://www.skypack.dev/ solve this? I.e. convert to ESM on the fly? |
Parceljs.org seems like it's both able to do that and not too difficult to handle. I'll give it a try. |
I had been trying to use parcel before, but it didn't properly build our types... this seems to do the trick. Fixes #38. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
@tvvignesh if you're still using this, I'd appreciate feedback on the draft PR ☝️ Does it do the trick? |
I had been trying to use parcel before, but it didn't properly build our types... this seems to do the trick. Fixes #38. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
I can help with that. Are you agree to propose a PR? |
@jorgecasar yeah that would be great. When playing with microbundle (#87), it seemed like you could have both, a commonJS and an ES module. I think that's what we'd want? 🤔 |
I see that tests are not working. In my case the results are: I was using nodejs 16.9.1 |
So we're using 12 and 14 in CI. Is it time to enable 16? 🤔 Can you share what breaks for you? (Otherwise I'll try it next week.) |
I just run |
Isn't this done? Hmm. |
Also from #36:
The text was updated successfully, but these errors were encountered: