Fix crash in v0.27.0 when s3_signing is configured #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by new logger not getting properly initialized in NewClient call. Fixes open-policy-agent#3255 Signed-off-by: Anders Eknert <anders@eknert.com>
srenatus
approved these changes
Mar 12, 2021
srenatus
reviewed
Mar 12, 2021
| authPlugin := &awsSigningAuthPlugin{ | ||
| AWSEnvironmentCredentials: &awsEnvironmentCredentialService{}, | ||
| } | ||
| client, err := New([]byte(config), map[string]*keys.Config{}, AuthPluginLookup(func(name string) HTTPAuthPlugin { |
There was a problem hiding this comment.
[nit]
Suggested change
| client, err := New([]byte(config), map[string]*keys.Config{}, AuthPluginLookup(func(name string) HTTPAuthPlugin { | |
| client, err := New([]byte(config), map[string]*keys.Config{}, AuthPluginLookup(func(string) HTTPAuthPlugin { |
srenatus
reviewed
Mar 12, 2021
| @@ -1277,6 +1277,38 @@ func TestOauth2ClientCredentialsJwtAuthentication(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // https://github.com/open-policy-agent/opa/issues/3255 | |||
| func TestS3SigningInstantiationInitializesLogger(t *testing.T) { | |||
| config := fmt.Sprintf(`{ | |||
There was a problem hiding this comment.
[nit] There doesn't seem to be a need for Sprintf here.
Suggested change
| config := fmt.Sprintf(`{ | |
| config := `{ |
|
Merely low-priority nitpicks. Merging. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by new logger not getting properly initialized in NewClient
call.
Fixes #3255
Signed-off-by: Anders Eknert anders@eknert.com