Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/website] Link to OPA Ecosystem from docs #6064

Merged
merged 5 commits into from Jul 3, 2023
Merged

[docs/website] Link to OPA Ecosystem from docs #6064

merged 5 commits into from Jul 3, 2023

Conversation

charlieegan3
Copy link
Contributor

This PR makes the following changes to the website Ecosystem content and linking:

  • Creates and assigns categories to various projects where information is available.
  • Displays top level categories on Ecosystem page
  • Links to categories from various relevant locations within the docs.
  • Embeds related Ecosystem projects at the ends of some docs pages where there are fewer than 6 and all have related content to the page in question.
  • Implements Hugo partials and shortcodes to make this extensible in future.
  • Updates to ecosystem projects to keep them current
  • Adds various, previously unlisted, OPA ecosystem projects

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 790aa8e
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/64a2f44d2d4ae20008aaa78f
😎 Deploy Preview https://deploy-preview-6064--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@charlieegan3 charlieegan3 marked this pull request as ready for review July 3, 2023 09:39
@srenatus
Copy link
Contributor

srenatus commented Jul 3, 2023

I wasn't able to find out by myself -- what determines the use of "by VENDOR" vs plain "VENDOR" here? 👇

image

@srenatus
Copy link
Contributor

srenatus commented Jul 3, 2023

https://github.com/open-policy-agent/opa/pull/6064/files#diff-d7824d254a89d3d00b2f4b30619017056bb7c90bb335a493d4dae59eb38ecbe7R16-R24 found it. Nevermind ✔️

srenatus
srenatus previously approved these changes Jul 3, 2023
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive Hugo skills here. And the outcome looks great. Thanks a lot. 👏

This PR makes the following changes to the website Ecosystem content and
linking:

* Creates and assigns categories to various projects where information
  is available.
* Displays top level categories on Ecosystem page
* Links to categories from various relevant locations within the docs.
* Embeds related Ecosystem projects at the ends of some docs pages where
  there are fewer than 6 and all have related content to the page in
  question.
* Implements Hugo partials and shortcodes to make this extensible in
  future.
* Updates to ecosystem projects to keep them current
* Adds various, previously unlisted, OPA ecosystem projects

Signed-off-by: Charlie Egan <charlie@styra.com>
philipaconrad
philipaconrad previously approved these changes Jul 3, 2023
Copy link
Contributor

@philipaconrad philipaconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @srenatus noted, there's a substantial amount of Hugo partials-wrangling going on here. Well done-- the results looks great! 😄

@srenatus
Copy link
Contributor

srenatus commented Jul 3, 2023

It looks a bit too wide on my mobile, but that shouldn't block merging this great improvement. Also, I'm too daft to create a screenshot right now 😅

@charlieegan3
Copy link
Contributor Author

It looks a bit too wide on my mobile

👍 Ahh, I think I can fix that.

Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
ashutosh-narkar
ashutosh-narkar previously approved these changes Jul 3, 2023
* Management APIs
* Envoy

Signed-off-by: Charlie Egan <charlie@styra.com>
@charlieegan3
Copy link
Contributor Author

0035ca9 adds a few more ecosystem project sections.

@srenatus
Copy link
Contributor

srenatus commented Jul 3, 2023

Mobile looks good now, thanks!

Signed-off-by: Charlie Egan <charlie@styra.com>
@charlieegan3 charlieegan3 merged commit f74a5f6 into open-policy-agent:main Jul 3, 2023
25 checks passed
@charlieegan3 charlieegan3 deleted the ecosystem-linking branch July 3, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants