Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job log path when job folder is empty #135

Merged
merged 1 commit into from Jul 8, 2019
Merged

Fix job log path when job folder is empty #135

merged 1 commit into from Jul 8, 2019

Conversation

narasimhan-v
Copy link
Collaborator

job.log path is computed from job folder. In cases like dry run,
the path is empty. Handling this case with this commit.

Signed-off-by: Narasimhan V sim@linux.vnet.ibm.com

@narasimhan-v
Copy link
Collaborator Author

Before fix:

host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest           Run        Successfully executed
grep: /root/sim/avocado-fvt-wrapper/results/*/job.log
 
host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest.2         Run        Successfully executed
grep: /root/sim/avocado-fvt-wrapper/results/*/job.log
 
host_io_test_fvt_nvmetest_NVMeTest_test_create_max_ns_nvmetest              Run        Successfully executed
grep: /root/sim/avocado-fvt-wrapper/results/*/job.log
 
host_io_test_fvt_nvmetest_NVMeTest_test_create_full_capacity_ns_nvmetest    Run        Successfully executed
grep: /root/sim/avocado-fvt-wrapper/results/*/job.log

@narasimhan-v
Copy link
Collaborator Author

After fix:

# python avocado-setup.py --run-suite host_io_test_fvt --disable-kvm --additional-args " -d"
02:28:36 INFO    : Check for environment
02:28:36 INFO    : Creating temporary mux dir
02:28:37 INFO    : 
02:28:37 INFO    : Running Host Tests Suite io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest
02:28:37 INFO    : Running: /usr/bin/avocado run avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade$ -m /root/sim/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/ssd/nvmetest.py.data/nvmetest.yaml --force-job-id e5fb87dbdbada6e2286a8376ab6b40850d35b200  -d --job-results-dir /root/sim/avocado-fvt-wrapper/results
JOB ID     : e5fb87dbdbada6e2286a8376ab6b40850d35b200
JOB LOG    : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-e5fb87d/job.log
 (1/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-upstream-nvme-cli-0ed7: CANCEL: Test cancelled due to --dry-run (0.00 s)
 (2/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-distro-nvme-cli-893a: CANCEL: Test cancelled due to --dry-run (0.00 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2
JOB TIME   : 0.62 s
JOB HTML   : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-e5fb87d/results.html
02:28:38 INFO    : 
02:28:38 INFO    : 
02:28:38 INFO    : Running Host Tests Suite io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest.2
02:28:38 INFO    : Running: /usr/bin/avocado run avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade$ -m /root/sim/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/ssd/nvmetest.py.data/nvmetest.yaml --force-job-id 3492d0f8f4f86f7f563b0999831614a9cd35a38a  -d --job-results-dir /root/sim/avocado-fvt-wrapper/results
JOB ID     : 3492d0f8f4f86f7f563b0999831614a9cd35a38a
JOB LOG    : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-3492d0f/job.log
 (1/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-upstream-nvme-cli-0ed7: CANCEL: Test cancelled due to --dry-run (0.00 s)
 (2/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-distro-nvme-cli-893a: CANCEL: Test cancelled due to --dry-run (0.00 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2
JOB TIME   : 0.34 s
JOB HTML   : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-3492d0f/results.html
02:28:39 INFO    : 
02:28:39 INFO    : Summary of test results can be found below:
TestSuite                                                                   TestRun    Summary             
 
host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest           Not_Run    Finding job.log failed

 
host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest.2         Not_Run    Finding job.log failed

02:28:39 INFO    : Removing temporary mux dir

# python avocado-setup.py --run-suite host_io_test_fvt --disable-kvm
02:28:44 INFO    : Check for environment
02:28:44 INFO    : Creating temporary mux dir
02:28:45 INFO    : 
02:28:45 INFO    : Running Host Tests Suite io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest
02:28:45 INFO    : Running: /usr/bin/avocado run avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade$ -m /root/sim/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/ssd/nvmetest.py.data/nvmetest.yaml --force-job-id 48105eff57efaadd015d245b09abb4831853e203  --job-results-dir /root/sim/avocado-fvt-wrapper/results
JOB ID     : 48105eff57efaadd015d245b09abb4831853e203
JOB LOG    : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-48105ef/job.log
 (1/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-upstream-nvme-cli-0ed7: CANCEL: firmware url not given (3.04 s)
 (2/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-distro-nvme-cli-893a: CANCEL: firmware url not given (0.50 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2
JOB TIME   : 4.03 s
JOB HTML   : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-48105ef/results.html
02:28:49 INFO    : 
02:28:49 INFO    : 
02:28:49 INFO    : Running Host Tests Suite io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest.2
02:28:49 INFO    : Running: /usr/bin/avocado run avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade$ -m /root/sim/avocado-fvt-wrapper/tests/avocado-misc-tests/io/disk/ssd/nvmetest.py.data/nvmetest.yaml --force-job-id 3bbbb8b3953bd642a677552c41465b4709235861  --job-results-dir /root/sim/avocado-fvt-wrapper/results
JOB ID     : 3bbbb8b3953bd642a677552c41465b4709235861
JOB LOG    : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-3bbbb8b/job.log
 (1/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-upstream-nvme-cli-0ed7: CANCEL: firmware url not given (3.08 s)
 (2/2) avocado-misc-tests/io/disk/ssd/nvmetest.py:NVMeTest.test_firmware_upgrade;firmware_url-distro-nvme-cli-893a: CANCEL: firmware url not given (0.56 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 2
JOB TIME   : 4.21 s
JOB HTML   : /root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-3bbbb8b/results.html
02:28:54 INFO    : 
02:28:54 INFO    : Summary of test results can be found below:
TestSuite                                                                   TestRun    Summary             
 
host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest           Run        Successfully executed
/root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-48105ef/job.log
 
host_io_test_fvt_nvmetest_NVMeTest_test_firmware_upgrade_nvmetest.2         Run        Successfully executed
/root/sim/avocado-fvt-wrapper/results/job-2019-07-04T02.28-3bbbb8b/job.log
02:28:54 INFO    : Removing temporary mux dir

sathnaga
sathnaga reviewed Jul 8, 2019
View reviewed changes
avocado-setup.py Outdated
result_link += "/job.log"
testsuite.runstatus("Run", "Successfully executed", result_link)
else:
testsuite.runstatus("Not_Run", "Finding job.log failed")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to find job log file or missing job log file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathnaga thanks, pushed.

sathnaga
sathnaga reviewed Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@sathnaga sathnaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion.

@narasimhan-v
Fix job log path when job folder is empty
fa809a0 
job.log path is computed from job folder. In cases like dry run,
the path is empty. Handling this case with this commit.

Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>
@sathnaga sathnaga merged commit f12b2cc into lop-devops:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathnaga sathnaga sathnaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@narasimhan-v @sathnaga