Skip to content

Commit

Permalink
HB Implement Static Analysis with cppcheck
Browse files Browse the repository at this point in the history
Inline cppcheck-suppressions for false positives.
HB (which pulls in files edited here) will start having the option to
implement cppcheck.

Change-Id: I08adcf3a344295621c5730fc04516f806c6b85bd
RTC: 201451
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82267
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: Glenn Miles <milesg@ibm.com>
Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
  • Loading branch information
LF-Luis authored and op-jenkins committed Sep 5, 2019
1 parent c7e1ca8 commit 8df77fd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion import/chips/p9/xip/p9_xip_image.h
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HCODE Project */
/* */
/* COPYRIGHT 2015,2018 */
/* COPYRIGHT 2015,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -1619,6 +1619,7 @@ p9_xip_decode_toc_dump(void* i_image, void* i_dump,
.macro .xip_toc, index:req, type:req, address:req, elements=1

.if (((\type) < 1) || ((\type) > P9_XIP_MAX_TYPE_INDEX))
// cppcheck-suppress syntaxError
.error ".xip_toc : Illegal type index"
.endif

Expand Down

0 comments on commit 8df77fd

Please sign in to comment.