Skip to content

Commit

Permalink
Remove disable of Pstates on a transition to standby state
Browse files Browse the repository at this point in the history
Change-Id: Ifb472824c63edf0564b93611b6bc96c76ce1d9c4
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57080
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Andres A. Lugo-Reyes <aalugore@us.ibm.com>
Reviewed-by: Christopher J. Cain <cjcain@us.ibm.com>
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: Martha Broyles <mbroyles@us.ibm.com>
  • Loading branch information
marthabroyles committed Apr 12, 2018
1 parent 6c9f28e commit bee2601
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/occ_405/occbuildname.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ volatile const char G_occ_buildname[16] __attribute__((section(".buildname"))) =

#else

volatile const char G_occ_buildname[16] __attribute__((section(".buildname"))) = /*<BuildName>*/ "op_occ_180410a\0" /*</BuildName>*/ ;
volatile const char G_occ_buildname[16] __attribute__((section(".buildname"))) = /*<BuildName>*/ "op_occ_180411a\0" /*</BuildName>*/ ;

#endif
14 changes: 2 additions & 12 deletions src/occ_405/state.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ errlHndl_t SMGR_standby_to_characterization()
errlHndl_t SMGR_all_to_standby()
{
uint32_t wait_time = 0;
int rc;

TRAC_IMP("SMGR: Transition from State (%d) to Standby Started", CURRENT_STATE());

Expand All @@ -349,18 +348,9 @@ errlHndl_t SMGR_all_to_standby()
TRAC_ERR("SMGR_all_to_standby: Timeout waiting for Pstates start/suspend IPC task. OCCFLG[0x%08X]",
in32(OCB_OCCFLG));
}
// Stop Pstates if enabled
else if(G_proc_pstate_status == PSTATES_ENABLED)
{
rc = pgpe_start_suspend(PGPE_ACTION_PSTATE_STOP, G_proc_pmcr_owner);
if(rc)
{
TRAC_ERR("SMGR_all_to_standby: Failed to stop the pstate protocol on PGPE. rc[0x%08X] OCCFLG[0x%08X]",
rc, in32(OCB_OCCFLG));
}
}
// Leave pState protocol alone so if we are exiting active state the PGPE will take action
// when the watchdog goes off

// Pstates should be disabled, ready to safely transition to standby
// Set the RTL Flags to indicate which tasks can run
// - Clear ACTIVE b/c not in ACTIVE State
// - Clear OBSERVATION b/c not in CHARACTERIZATION State
Expand Down

0 comments on commit bee2601

Please sign in to comment.