rt_xstop_analysis: minor cleanups/tweaks

- Fix fir data collection functions' description
- change pk trace buffer size to 256 bytes
- add trace to main.c to indicate we failed to schedule
  fir data collection job
- add comment to clarify pnor data buffer changes

Change-Id: Ie6f68dd30b4382df95adae1fe420abcabf67033c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43449
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>

src/occ_405/main.c

@@ -153,7 +153,6 @@ FIR_HEAP_BUFFER(uint8_t G_fir_heap[FIR_HEAP_SECTION_SIZE]);
 FIR_PARMS_BUFFER(uint8_t G_fir_data_parms[FIR_PARMS_SECTION_SIZE]);
 uint32_t G_fir_master = FIR_OCC_NOT_FIR_MASTER;
 bool G_fir_collection_request_created = FALSE;
-GPE_BUFFER(ipc_scom_op_t G_scom_op);
 GpeRequest G_fir_collection_request;
 
 /*
@@ -1716,7 +1715,11 @@ void Main_thread_routine(void *private)
                     {
                         G_fir_collection_request_created = TRUE;
                         TRAC_IMP("fir data collection: scheduling gpe request");
-                        gpe_request_schedule(&G_fir_collection_request);
+                        l_rc = gpe_request_schedule(&G_fir_collection_request);
+                        {
+                            TRAC_IMP("failed to schedule fir data collection job");
+                        }
+
                         L_fir_collection_completed = TRUE;
                         G_fir_collection_required = FALSE;
                     }

src/occ_gpe0/firdata/pnorData_common.h

@@ -142,6 +142,7 @@ static inline PNOR_Trgt_t PNOR_getTrgt( uint32_t i_trgtType, uint32_t i_chipPos,
 
 /** Information for a normal register. */
 /* NOTE: This structure is 4-byte word aligned. */
+//The order matters here due to hardware limitations on the GPE
 typedef struct __attribute__((packed))
 {
     uint64_t val;   /** 64-bit value */

src/occ_gpe0/gpe_util.c

@@ -223,7 +223,7 @@ void ipc_scom_operation(ipc_msg_t* cmd, void* arg)
  *
  * Name: ipc_fir_collection
  *
- * Description: Does a getscom or putscom for the 405
+ * Description: Does fir data collection in case of a checkstop
  *
  * End Function Specification
  */

src/ppe/pk/trace/pk_trace.h

@@ -34,7 +34,7 @@
 #define PK_TRACE_VERSION 2
 
 #ifndef PK_TRACE_SZ
-#define PK_TRACE_SZ 4096 //@pragupta_todo -- only for debug
+#define PK_TRACE_SZ 256
 #endif
 
 //Fail compilation if size is not a power of 2