-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPI testcases #94
CAPI testcases #94
Conversation
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
# @return BMC_CONST.FW_SUCCESS or raise OpTestError | ||
# | ||
def host_clone_cxl_tests(self, i_dir): | ||
l_msg = "https://github.com/ibm-capi/cxl-tests.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like ibm-capi/cxl-tests repository is not open to all, it is asking for username/password. cloning is failing. Then it will be difficult to run this tests for all the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I am working at open sourcing cxl-tests.
else: | ||
l_msg = "Host has no CAPI FPGA card" | ||
print l_msg | ||
raise OpTestError(l_msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the systems may not be having capi card, instead of raising the error, just print a message says like "No CAPI card, skipping the tests..." and just return it without running the tests(i.e skip the tests if there is no CAPI card). or you can catch this OpTestError exception in your four tests and return there if test got this exception.
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
Paidipeddi Pridhiviraj <notifications@github.com> writes:
pridhiviraj commented on this pull request.
> + # @brief Check that host has a CAPI FPGA card
+ #
+ # @return BMC_CONST.FW_SUCCESS or raise OpTestError
+ #
+ def host_has_capi_fpga_card(self):
+ l_cmd = "lspci -d \"1014:0477\""
+ print l_cmd
+ l_res = self.host_run_command(l_cmd)
+ print l_res
+ if (l_res.__contains__('IBM Device 0477')):
+ l_msg = "Host has a CAPI FPGA card"
+ print l_msg
+ else:
+ l_msg = "Host has no CAPI FPGA card"
+ print l_msg
+ raise OpTestError(l_msg)
All the systems may not be having capi card, instead of raising the
error, just print a message says like "No CAPI card, skipping the
tests..." and just return it without running the tests(i.e skip the
tests if there is no CAPI card). or you can catch this OpTestError
exception in your four tests and return there if test got this
exception.
The PCI device presence tests *should* catch any case where there's
meant to be a FPGA CAPI card but there isn't, so skipping the test here
should be okay.
…--
Stewart Smith
OPAL Architect, IBM.
|
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
Hi @philippe56 Thanks |
@pridhiviraj do you have access to a system with an appropriate CAPI card for this? If so, maybe you could do some conversion of the test? |
@stewart-ibm i don't have the system which is having CAPI card in handy, I will check with @PavamanSubramaniyam for system availability. I can do the conversion of test. |
Sorry for the late answer. I have been diverted by management from working on this in the past week. I can do the conversion and test it. I have access to a test system with an appropriate CAPI card. Also, I have been granted company clearance for opening the repository ibm-capi/cxl-tests. |
philippe56 <notifications@github.com> writes:
Sorry for the late answer. I have been diverted by management from working on this in the past week.
I can do the conversion and test it. I have access to a test system with an appropriate CAPI card.
Also, I have been granted company clearance for opening the repository
ibm-capi/cxl-tests.
Ahh great!
The good news is that things should be much easier to develop for now. :)
…--
Stewart Smith
OPAL Architect, IBM.
|
@philippe56 You have any implemented patches for this with respect to new framework? |
@pridhiviraj No I have not. My priorities have changed again, and I could not keep the promise I made above. I would appreciate if you could help porting this branch to the new framework, reusing the test code in https://github.com/ibm-capi/cxl-tests, that does exist now. |
@philippe56 Sure, will do the required porting in my free time, and need a system with OpenCAPI card to test it. So i will ping you for system for some time. |
This patch is ported from the below PR. Which is the initial work done by Philippe Bergheaud. open-power#94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
This patch is ported from the below PR. Which is the initial work done by Philippe Bergheaud. open-power#94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
work done by Philippe Bergheaud. open-power#94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
work done by Philippe Bergheaud. open-power#94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
work done by Philippe Bergheaud. open-power#94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
work done by Philippe Bergheaud. #94 Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Superseded by #200 |
This change is