Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI testcases #94

Closed
wants to merge 4 commits into from
Closed

CAPI testcases #94

wants to merge 4 commits into from

Conversation

philippe56
Copy link
Contributor

@philippe56 philippe56 commented Dec 12, 2016

This change is Reviewable

Philippe Bergheaud added 2 commits December 8, 2016 13:51
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
# @return BMC_CONST.FW_SUCCESS or raise OpTestError
#
def host_clone_cxl_tests(self, i_dir):
l_msg = "https://github.com/ibm-capi/cxl-tests.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ibm-capi/cxl-tests repository is not open to all, it is asking for username/password. cloning is failing. Then it will be difficult to run this tests for all the users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I am working at open sourcing cxl-tests.

else:
l_msg = "Host has no CAPI FPGA card"
print l_msg
raise OpTestError(l_msg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the systems may not be having capi card, instead of raising the error, just print a message says like "No CAPI card, skipping the tests..." and just return it without running the tests(i.e skip the tests if there is no CAPI card). or you can catch this OpTestError exception in your four tests and return there if test got this exception.

Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
@ghost
Copy link

ghost commented Dec 19, 2016 via email

Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
@pridhiviraj
Copy link
Contributor

Hi @philippe56
Can you pleas convert this to new test framework, Let me or @stewart-ibm know if you face any issues while converting it.

Thanks

@ghost
Copy link

ghost commented Mar 15, 2017

@pridhiviraj do you have access to a system with an appropriate CAPI card for this?

If so, maybe you could do some conversion of the test?

@pridhiviraj
Copy link
Contributor

@stewart-ibm i don't have the system which is having CAPI card in handy, I will check with @PavamanSubramaniyam for system availability. I can do the conversion of test.

@philippe56
Copy link
Contributor Author

Sorry for the late answer. I have been diverted by management from working on this in the past week.

I can do the conversion and test it. I have access to a test system with an appropriate CAPI card.

Also, I have been granted company clearance for opening the repository ibm-capi/cxl-tests.

@ghost
Copy link

ghost commented Mar 15, 2017 via email

@pridhiviraj
Copy link
Contributor

@philippe56 You have any implemented patches for this with respect to new framework?

@philippe56
Copy link
Contributor Author

@pridhiviraj No I have not. My priorities have changed again, and I could not keep the promise I made above. I would appreciate if you could help porting this branch to the new framework, reusing the test code in https://github.com/ibm-capi/cxl-tests, that does exist now.

@pridhiviraj
Copy link
Contributor

@philippe56 Sure, will do the required porting in my free time, and need a system with OpenCAPI card to test it. So i will ping you for system for some time.

pridhiviraj added a commit to pridhiviraj/op-test-framework that referenced this pull request Feb 15, 2018
This patch is ported from the below PR. Which is the initial
work done by Philippe Bergheaud.
open-power#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
pridhiviraj added a commit to pridhiviraj/op-test-framework that referenced this pull request Feb 15, 2018
This patch is ported from the below PR. Which is the initial
work done by Philippe Bergheaud.
    open-power#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
pridhiviraj added a commit to pridhiviraj/op-test-framework that referenced this pull request Feb 15, 2018
work done by Philippe Bergheaud.
open-power#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Philippe Bergheaud <felix@linux.vnet.ibm.com>
pridhiviraj added a commit to pridhiviraj/op-test-framework that referenced this pull request Feb 16, 2018
work done by Philippe Bergheaud.
open-power#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
pridhiviraj added a commit to pridhiviraj/op-test-framework that referenced this pull request Feb 16, 2018
work done by Philippe Bergheaud.
open-power#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
ghost pushed a commit that referenced this pull request Feb 23, 2018
work done by Philippe Bergheaud.
#94

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
@ghost
Copy link

ghost commented Feb 23, 2018

Superseded by #200

@ghost ghost closed this Feb 23, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants