Skip to content

Commit

Permalink
Add SPD DDIMM DDR4 module except for PMIC fields
Browse files Browse the repository at this point in the history
Change-Id: If5bb07a8f6655da1b941f89ef15ff247ce442a74
Original-Change-Id: Ib5268d2bc425733d30fbca98eaeb8d4a62a918a2
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69838
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
  • Loading branch information
aamarin authored and Raja Das committed Jul 26, 2019
1 parent 0248d11 commit 13e163d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/import/generic/memory/lib/utils/mss_field.H
Expand Up @@ -179,6 +179,9 @@ inline fapi2::ReturnCode get_field(const fapi2::Target<T>& i_target,
const FFDC i_ffdc_codes,
OT& o_value)
{
// Initializes the output value to 0, that way, we won't have any stale data in o_value
o_value = 0;

const size_t BYTE = F.get_byte(i_data);

FAPI_ASSERT( BYTE < i_data.size(),
Expand Down
Expand Up @@ -136,6 +136,9 @@ enum generic_ffdc_codes
SET_HYBRID_MEDIA = 0x1028,
SET_MRANKS = 0x1029,
SET_DIMM_RANKS_CNFG = 0x1039,

// SPD fields function codes
DDIMM_RAWCARD_DECODE = 0x103a,
};

///
Expand Down Expand Up @@ -193,6 +196,7 @@ namespace spd
///
enum rev : uint8_t
{
V0_0 = 0x00, ///< represents Rev 0.0
V1_0 = 0x10, ///< represents Rev 1.0
V1_1 = 0x11, ///< represents Rev 1.1
V1_2 = 0x12, ///< represents Rev 1.2
Expand All @@ -202,6 +206,7 @@ enum rev : uint8_t
GEN_SEC_MAX = V1_1,
RDIMM_MAX = V1_1,
LRDIMM_MAX = V1_2,
DDIMM_MAX = V1_0,
};

///
Expand All @@ -215,6 +220,7 @@ enum parameters
RDIMM_MODULE,
LRDIMM_MODULE,
NVDIMM_MODULE,
DDIMM_MODULE,
};

///
Expand All @@ -234,6 +240,7 @@ enum dimm_type
{
RDIMM = 0b0001,
LRDIMM = 0b0100,
DDIMM = 0b1010,
};

enum guard_band : uint16_t
Expand Down

0 comments on commit 13e163d

Please sign in to comment.