Skip to content

Commit

Permalink
Procedure crashes when trying to query an EC feature
Browse files Browse the repository at this point in the history 
    -Updated queryEcFeature to have two parts, base
     attribute reading is now in a library, while
     feature checking logic is now in small individual
     inline functions.

Change-Id: I7d41eb80d4a1da853118323fb12dc884054a01da
Original-Change-Id: I4c3685d6a85946297af31f7f3da4d918bca88039
RTC:151184
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/23025
Tested-by: Jenkins Server
Tested-by: PPE CI
Tested-by: Hostboot CI
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
  • Loading branch information
@rjknight @Shakeebbk
rjknight authored and Shakeebbk committed Sep 12, 2017
1 parent 076e8c7 commit 200b0ea
Showing 1 changed file with 76 additions and 0 deletions.
76 changes: 76 additions & 0 deletions src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml
View file
@@ -0,0 +1,76 @@
<!-- IBM_PROLOG_BEGIN_TAG -->
<!-- This is an automatically generated prolog. -->
<!-- -->
<!-- $Source: src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml $ -->
<!-- -->
<!-- OpenPOWER sbe Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2016,2017 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
<!-- Licensed under the Apache License, Version 2.0 (the "License"); -->
<!-- you may not use this file except in compliance with the License. -->
<!-- You may obtain a copy of the License at -->
<!-- -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or -->
<!-- implied. See the License for the specific language governing -->
<!-- permissions and limitations under the License. -->
<!-- -->
<!-- IBM_PROLOG_END_TAG -->
<!--
XML file specifying HWPF attributes.
These are example Chip EC Feature attributes that specify chip features
based on the EC level of a chip
-->

<attributes>
<!-- ********************************************************************* -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_TEST1</id>
<targetType>TARGET_TYPE_PROC_CHIP, TARGET_TYPE_MEMBUF_CHIP</targetType>
<description>
Returns if a chip contains the TEST1 feature. True if either:
Centaur EC 10
Venice EC greater than 30
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_CENTAUR</name>
<ec>
<value>0x10</value>
<test>EQUAL</test>
</ec>
</chip>
<chip>
<name>ENUM_ATTR_NAME_CUMULUS</name>
<ec>
<value>0x30</value>
<test>GREATER_THAN</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
<!-- ********************************************************************* -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_TEST2</id>
<targetType>TARGET_TYPE_PROC_CHIP, TARGET_TYPE_MEMBUF_CHIP</targetType>
<description>
Returns if a chip contains the TEST2 feature. True if:
Murano EC less than 20
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
<test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
</attributes>

0 comments on commit 200b0ea

Please sign in to comment.