Fix in quisce

Change-Id: Id64bf0b948e65b142e47b777f937ffe4bf530d55 CQ: SW437514 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62208 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Shakeeb A. Pasha B K <shakeebbk@in.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> (cherry picked from commit c2da12c625e492988947fdb872424f10d0b8b4b1) Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62293
open-power · Jul 12, 2018 · 2c410f1 · 2c410f1
1 parent ddefd50
commit 2c410f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/sbefw/app/common/sbecmdgeneric.C b/src/sbefw/app/common/sbecmdgeneric.C
@@ -438,7 +438,7 @@ uint32_t sbeFifoQuiesce( uint8_t *i_pArg )
         int pkRc = pk_thread_suspend(&SBE_GLOBAL->sbeAsyncCommandProcessor_thread);
         if (pkRc != PK_OK)
         {
-            SBE_ERROR(SBE_FUNC "async thread suspend failed");
+            SBE_ERROR(SBE_FUNC "async thread suspend failed. pkRc:%u", (-pkRc));
             respHdr.setStatus( SBE_PRI_GENERIC_EXECUTION_FAILURE,
                                SBE_SEC_OS_FAILURE);
             break;
@@ -464,6 +464,7 @@ uint32_t sbePsuQuiesce( uint8_t *i_pArg )
 {
     #define SBE_FUNC "sbePsuQuiesce"
     uint32_t rc = SBE_SEC_OPERATION_SUCCESSFUL;
+    uint32_t fapiRc = FAPI2_RC_SUCCESS;
 
     do
     {
@@ -480,9 +481,9 @@ uint32_t sbePsuQuiesce( uint8_t *i_pArg )
 
         // Suspend async task
         int pkRc = pk_thread_suspend(&SBE_GLOBAL->sbeAsyncCommandProcessor_thread);
-        if (pkRc == PK_OK)
+        if (pkRc != PK_OK)
         {
-            SBE_ERROR(SBE_FUNC "async thread suspend failed");
+            SBE_ERROR(SBE_FUNC "async thread suspend failed. pkRc:%u", (-pkRc));
             SBE_GLOBAL->sbeSbe2PsuRespHdr.setStatus(
                     SBE_PRI_GENERIC_EXECUTION_FAILURE,
                     SBE_SEC_OS_FAILURE);
@@ -495,10 +496,7 @@ uint32_t sbePsuQuiesce( uint8_t *i_pArg )
 
     }while(0);
 
-    rc = sbeWriteSbe2PsuMbxReg(SBE_HOST_PSU_MBOX_REG4,
-                     (uint64_t*)(&SBE_GLOBAL->sbeSbe2PsuRespHdr),
-                     (sizeof(SBE_GLOBAL->sbeSbe2PsuRespHdr)/sizeof(uint64_t)),
-                     true);
+    sbePSUSendResponse(SBE_GLOBAL->sbeSbe2PsuRespHdr, fapiRc, rc);
     if(rc != SBE_SEC_OPERATION_SUCCESSFUL)
     {
         SBE_ERROR( SBE_FUNC"Failed to write SBE_HOST_PSU_MBOX_REG4. rc[0x%X]", rc);

diff --git a/src/sbefw/core/pk_app_cfg.h b/src/sbefw/core/pk_app_cfg.h
@@ -146,5 +146,5 @@
 #ifdef PK_TRACE_SZ
 #undef PK_TRACE_SZ
 #endif
-#define PK_TRACE_SZ 128
+#define PK_TRACE_SZ 256
 #endif /*__PK_APP_CFG_H__*/