Skip to content

Commit

Permalink
Fix p9_mss_utils_to_throttle, create throttles API, attribute cleanup
Browse files Browse the repository at this point in the history
Change-Id: Ibdb563542adb9e4f05dd07d597a9687b1deaf3c8
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27183
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69770
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
aamarin authored and sgupta2m committed Dec 18, 2018
1 parent 7a955f6 commit 2ce64ff
Showing 1 changed file with 16 additions and 43 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1254,12 +1254,11 @@

<attribute>
<id>ATTR_MSS_MEM_M_DRAM_CLOCKS</id>
<!-- TK Verify creator and consumer is correct for p9 AAM -->
<targetType>TARGET_TYPE_MCS</targetType>
<description>
This is the throttled M DRAM clocks setting for cfg_nm_m.
creator: mss_eff_cnfg
consumer: mc_config
consumer: mss_eff_config_thermal
firmware notes: none
</description>
<initToZero></initToZero>
Expand Down Expand Up @@ -2130,28 +2129,6 @@
<mssAccessorName>lrdimm_rank_mult_mode</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_MSS_THROTTLE_CONTROL_RAS_WEIGHT</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>RAS weight to use for memory throttle control - set in thermal procedures</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<writeable/>
<array>2</array>
<mssAccessorName>throttle_control_ras_weight</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_MSS_THROTTLE_CONTROL_CAS_WEIGHT</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>CAS weight to use for memory throttle control - set in thermal procedures</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<writeable/>
<array>2</array>
<mssAccessorName>throttle_control_cas_weight</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_MSS_EFF_VPD_VERSION</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down Expand Up @@ -2219,36 +2196,32 @@
<attribute>
<id>ATTR_MSS_DATABUS_UTIL</id>
<targetType>TARGET_TYPE_MCS</targetType>
<!-- TK Do we need an attr per port & dimm ? P8 only had an attr per port AAM -->
<!-- TK Does OCC set this for their use, if so, name attr appropriately? AAM -->
<description>
DRAM data bus utilization percent to use to determine ATTR_MSS_THROTTLED_N_COMMANDS
creator: f/w
consumer: mss_utils_to_throttle
DRAM data bus utilization percent to use to determine cfg_nm_n_per_port
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<writeable/>
<array>2 2</array>
<array>2</array>
<mssAccessorName>databus_util</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_MSS_THROTTLED_N_COMMANDS</id>
<!-- TK We can throttle per port/dimm slot will one attr suffice? AAM -->
<targetType>TARGET_TYPE_MCS</targetType>
<description>
Throttled N commands (address operations) that are
allowed within a window of M DRAM clocks.
Nimbus workbook (Power and Thermal Controls).
creator: mss_utils_to_throttle
</description>
<initToZero></initToZero>
<valueType>uint32</valueType>
<writeable/>
<array>2 2</array>
<mssAccessorName>throttled_n_commands</mssAccessorName>
<id>ATTR_MSS_OCC_THROTTLED_N_CMDS</id>
<targetType>TARGET_TYPE_MCS</targetType>
<!-- TK Do we need an attr per port & dimm ? P8 only had an attr per port AAM -->
<description>
cfg_nm_n_per_port throttle N value that was calculated from MSS_DATABUS_UTIL
</description>
<initToZero></initToZero>
<valueType>uint32</valueType>
<writeable/>
<array>2</array>
<mssAccessorName>occ_throttled_n_cmds</mssAccessorName>
</attribute>


<attribute>
<id>ATTR_EFF_DRAM_MAC</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down

0 comments on commit 2ce64ff

Please sign in to comment.