Skip to content

Commit

Permalink
Generalize set fields in pre_data_init
Browse files Browse the repository at this point in the history
Added a definition file for data engine traits for
specialization purposes.  Moved pre_data_engine
definitions into a common templated version.

Change-Id: Ifb204da9cc6eb9d5d36b6eaeb1e1a5e99c97544e
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69411
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Dev-Ready: ANDRE A. MARIN <aamarin@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80975
Reviewed-by: RAJA DAS <rajadas2@in.ibm.com>
Tested-by: RAJA DAS <rajadas2@in.ibm.com>
  • Loading branch information
aamarin authored and RAJA DAS committed Jul 25, 2019
1 parent 0f8b952 commit 4338c9d
Show file tree
Hide file tree
Showing 2 changed files with 99 additions and 2 deletions.
33 changes: 31 additions & 2 deletions src/import/generic/memory/lib/utils/shared/mss_generic_consts.H
Expand Up @@ -130,15 +130,19 @@ enum generic_ffdc_codes
BASE_MODULE_TYPE = 0x101C,
BAD_SPD_DATA = 0x101D,
SET_FIELD = 0x101E,

// mss_freq functions
SELECT_SUPPORTED_FREQ = 0x101F,
FREQ_SCOREBOARD_REMOVE_FREQS_ABOVE_LIMIT = 0x1020,
FREQ_SCOREBOARD_REMOVE_FREQS_ABOVE_LIMIT_VECTOR = 0x1021,
FREQ_SCOREBOARD_REMOVE_FREQS_NOT_ON_LIST = 0x1022,
FREQ_SCOREBOARD_MAX_SUPPORTED_FREQ = 0x1023,
FREQ_SCOREBOARD_SUPPORTED_FREQS = 0x1024,
LIMIT_FREQ_BY_VPD = 0x1025,
SET_DIMM_TYPE = 0x1026,
SET_DRAM_GEN = 0x1027,
SET_HYBRID = 0x1027,
SET_HYBRID_MEDIA = 0x1028,
SET_MRANKS = 0x1029,
SET_DIMM_RANKS_CNFG = 0x1039,
};

///
Expand Down Expand Up @@ -311,6 +315,31 @@ struct procTraits<proc_type::AXONE>
};
};

///
/// @brief Trait classes for proc_type
///
template< proc_type P >
class procTraits;

///
/// @brief Trait classes for proc_type - NIMBUS specialization
///
template< >
struct procTraits<proc_type::NIMBUS>
{
enum
{
MC_PER_MODULE = 2,
MCS_PER_MC = 2,
MCS_PER_PROC = MC_PER_MODULE * MCS_PER_MC,
PORTS_PER_MCBIST = 4,
PORTS_PER_MCS = 2,
DIMMS_PER_PORT = 2,
DIMMS_PER_MCS = PORTS_PER_MCS * DIMMS_PER_PORT,
DIMMS_PER_MCBIST = PORTS_PER_MCBIST * DIMMS_PER_PORT,
};
};

}// mss

#endif
68 changes: 68 additions & 0 deletions src/import/generic/procedures/xml/error_info/generic_error.xml
Expand Up @@ -330,4 +330,72 @@
</callout>
</hwpError>

<hwpError>
<rc>RC_MSS_UNEXPECTED_VALUE_SEEN</rc>
<description> Invalid value seen versus the expected value wanted </description>
<ffdc>TARGET</ffdc>
<ffdc>EXPECTED</ffdc>
<ffdc>ACTUAL</ffdc>
<ffdc>FUNCTION</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>LOW</priority>
</callout>
</hwpError>

<hwpError>
<rc>RC_MSS_OUT_OF_BOUNDS_INDEXING</rc>
<description>
Desired index is larger than list (std::vector, array, etc.) size.
Likely a programming error.
</description>
<ffdc>TARGET</ffdc>
<ffdc>INDEX</ffdc>
<ffdc>LIST_SIZE</ffdc>
<ffdc>FUNCTION</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>LOW</priority>
</callout>
</hwpError>

<hwpError>
<rc>RC_MSS_CONVERSION_ERROR</rc>
<description>
Overflow or underflow occured converting one integral type to another.
This is a programming error.
</description>
<ffdc>TARGET</ffdc>
<ffdc>ORIGINAL_VAL</ffdc>
<ffdc>CONVERTED_VAL</ffdc>
<ffdc>FUNCTION</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>LOW</priority>
</callout>
</hwpError>

<hwpError>
<rc>RC_MSS_FAILED_DATA_INTEGRITY_CHECK</rc>
<description>
Bad data received.
Settings are incorrect for received data.
This could be code problem (decoding) or bad data.
</description>
<ffdc>VALUE</ffdc>
<ffdc>BYTE</ffdc>
<ffdc>FFDC_CODE</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>MEDIUM</priority>
</callout>
<callout>
<target>TARGET</target>
<priority>HIGH</priority>
</callout>
<deconfigure>
<target>TARGET</target>
</deconfigure>
</hwpError>

</hwpErrors>

0 comments on commit 4338c9d

Please sign in to comment.