Skip to content

Commit

Permalink
Adjust idec algorithm for Explorer B.0 format
Browse files Browse the repository at this point in the history
The update to B.0 doesn't allow for a change to the register that
previously contained the MAJOR_REVISION value.  Because of that
we are revising the logic that determines the EC level to be a
lookup based on a single number instead.

Ignore the MAJOR_RELEASE field from CHIP_INFO entirely, it will
always =1. Instead we will rely only on the EFUSE bits currently
designated for MINOR_RELEASE. Since we lost the ability to have
a common M.m we will just use a single incrementing value to
represent the ordinal revision number, regardless of major/minor,
i.e. the 1st revision is 0, the 2nd is 1, the 10th is 9, etc.
So that gives us these values for EFUSE_IMAGE_OUT_3[13:10]
  A.0 = 0 = 0x10 in Host Firmware
  A.1 = 1 = 0x11 in Host Firmware
  B.0 = 2 = 0x20 in Host Firmware
  B.1 = 3 = 0x21 in Host Firmware (if it were to happen)

Change-Id: I878491e8e004c231ce4dcd7abe887a947c7f3dc3
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/89764
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/89793
Reviewed-by: RAJA DAS <rajadas2@in.ibm.com>
  • Loading branch information
dcrowell77 authored and RAJA DAS committed Feb 7, 2020
1 parent 972885f commit 512f924
Showing 1 changed file with 4 additions and 3 deletions.
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER sbe Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2018,2019 */
/* Contributors Listed Below - COPYRIGHT 2018,2020 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -177,12 +177,13 @@ enum ecid_consts
enum idec_consts
{
EXPLR_CHIP_INFO_REG = 0x2134,
MAJOR_EC_BIT_START = 32,
MAJOR_EC_BIT_LENGTH = 4,
LOCATION_BIT_START = 44,
LOCATION_BIT_LENGTH = 4,
CHIPID_BIT_START = 56,
CHIPID_BIT_LENGTH = 8,

REVISION_BIT_START = 50,
REVISION_BIT_LENGTH = 4,
};


Expand Down

0 comments on commit 512f924

Please sign in to comment.