Skip to content

Commit

Permalink
Fix HB error with -Os compile flag due to eff_config
Browse files Browse the repository at this point in the history
Top level template is NOT unique between the two files
when using the -Os compile flag. The linker just picks
the wrong file template definition between p9a and p9n.
In -O3 everything is left in place, inline so it just works
which is why we didn't hit this error before in HB

Change-Id: I66fb7db0ee688367600fa1c83cbf6c96006ee0af
Original-Change-Id: I529f93fc91684ae14a132d96f518a5f66f036d4b
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80167
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
  • Loading branch information
aamarin authored and Raja Das committed Jul 26, 2019
1 parent 21be781 commit ab24d31
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -90,9 +90,9 @@ enum attr_delay_index
/// @brief enum list of explorer SPD derived attributes to set
/// @note these attrs are strictly derived from SPD
/// @warning wrapped in exp namesapce to be distinguished from
/// the generic attr_eff_engine_fields
/// the exp::attr_eff_engine_fields
///
enum attr_eff_engine_fields
enum class attr_eff_engine_fields
{
// Template recursive base case
ATTR_EFF_BASE_CASE = 0,
Expand All @@ -110,7 +110,7 @@ enum attr_eff_engine_fields
ADDRESS_MIRROR = 10,

// Dispatcher set to last enum value
ATTR_EFF_DISPATCHER = ADDRESS_MIRROR,
DISPATCHER = ADDRESS_MIRROR,
};

///
Expand Down

0 comments on commit ab24d31

Please sign in to comment.