Skip to content

Commit

Permalink
Fix eff_config, remove custom_dimm
Browse files Browse the repository at this point in the history
Change-Id: Icc9bf700cbdf41467c4b0733f878d98b5dd76fed
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27930
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69777
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Tested-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
JacobHarvey authored and sgupta2m committed Dec 18, 2018
1 parent 2afef5b commit b7da4b9
Showing 1 changed file with 2 additions and 39 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,24 +128,6 @@
<mssAccessorName>dimm_mfg_id_code</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_CUSTOM_DIMM</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>
DIMM is a custom DIMM. This is commonly known as a CDIMM,
but technically, we could support Custom DIMMs of different types than an UDIMM,
such as RDIMM and LRDIMM.
Created in mss_eff_cnfg
Use this attribute if you need to know if the Centaur is on the DIMM instead of on a planar.
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<enum>NO = 0, YES = 1</enum>
<writeable/>
<array>2 2 </array>
<mssAccessorName>eff_custom_dimm</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_DIMM_SPARE</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down Expand Up @@ -257,25 +239,6 @@
<mssAccessorName>eff_dimm_size</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_DRAM_BL</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>
Burst Length.
Used in various locations and is computed in mss_eff_cnfg.
Each memory channel will have a value.
creator: mss_eff_cnfg
consumer: various
firmware notes: none
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<enum>BL8 = 0, OTF = 1, BC4 = 2</enum>
<writeable/>
<array>2</array>
<mssAccessorName>eff_dram_bl</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_DRAM_CL</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down Expand Up @@ -1712,7 +1675,7 @@
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<enum>1NCLK = 1, 2NCLK = 2</enum>
<enum>1NCLK = 0, 2NCLK = 1</enum>
<writeable/>
<array>2</array>
<mssAccessorName>eff_rd_preamble</mssAccessorName>
Expand All @@ -1730,7 +1693,7 @@
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<enum>1NCLK = 1, 2NCLK = 2</enum>
<enum>1NCLK = 0, 2NCLK = 1</enum>
<writeable/>
<array>2</array>
<mssAccessorName>eff_wr_preamble</mssAccessorName>
Expand Down

0 comments on commit b7da4b9

Please sign in to comment.