Skip to content

Commit

Permalink
Attribute cleanup
Browse files Browse the repository at this point in the history 
Added mrwHide to a lot of platInit attributes, this will prevent
 them from showing up in the ServerWiz tool where the value will
 be hard to change.  Instead these will always rely on the default
 in the xml or explicit platform code to set.
Also removed a bunch of unused tags to clean things up.

Change-Id: Id237924d737392368c418cc31d6506f1f5598b98
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64233
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66013
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
@dcrowell77 @sgupta2m
dcrowell77 authored and sgupta2m committed Sep 22, 2018
1 parent e1a4637 commit c9b4851
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 98 deletions.
46 changes: 10 additions & 36 deletions src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
2133 = 2133,
2400 = 2400
</enum>
<writeable/>
<platInit/>
<writeable/>
<mssAccessorName>freq_pb_mhz</mssAccessorName>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -62,7 +62,6 @@
2000 = 2000,
2400 = 2400
</enum>
<writeable/>
<platInit/>
<mssAccessorName>freq_mca_mhz</mssAccessorName>
</attribute>
Expand All @@ -76,7 +75,6 @@
</description>
<valueType>uint32</valueType>
<platInit/>
<writeable/>
<array>4</array>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -90,7 +88,7 @@
</description>
<valueType>uint32</valueType>
<platInit/>
<writeable/>
<writeable/><!-- only for sim tools -->
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -102,7 +100,6 @@
</description>
<valueType>uint32</valueType>
<platInit/>
<writeable/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand Down Expand Up @@ -395,6 +392,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand Down Expand Up @@ -453,6 +451,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -478,6 +477,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand Down Expand Up @@ -858,9 +858,9 @@
</description>
<valueType>uint8</valueType>
<enum>HB_IPL = 0x1,HB_RUNTIME = 0x2,CACHE_CONTAINED = 0x4,CHIP_CONTAINED = 0x8,NONHB_IPL = 0x10</enum>
<persistRuntime/>
<writeable/>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand Down Expand Up @@ -891,8 +891,8 @@
(excludes system/memory select/group/chip fields)
</description>
<valueType>uint64</valueType>
<persistRuntime/>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -908,8 +908,8 @@
(excludes system/memory select/group/chip fields)
</description>
<valueType>uint64</valueType>
<persistRuntime/>
<platInit/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand Down Expand Up @@ -941,7 +941,7 @@
FLIPPED = 0x1
</enum>
<platInit/>
<persistRuntime/>
<mrwHide/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -956,7 +956,6 @@
<valueType>uint64</valueType>
<array>8</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -972,7 +971,6 @@
<valueType>uint64</valueType>
<array>8</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************* -->
Expand All @@ -988,7 +986,6 @@
<valueType>uint64</valueType>
<array>4</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -1004,7 +1001,6 @@
<valueType>uint64</valueType>
<array>4</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -1025,8 +1021,6 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<odmVisable/>
<odmChangeable/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1043,8 +1037,6 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<odmVisable/>
<odmChangeable/>
<enum>
128_B = 0x00,
256_B = 0x01,
Expand Down Expand Up @@ -1075,8 +1067,6 @@
</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
<odmChangeable/>
<array>8</array>
<persistRuntime/>
</attribute>
Expand Down Expand Up @@ -1112,8 +1102,6 @@
<valueType>uint32</valueType>
<array>16,21</array>
<writeable/>
<odmVisable/>
<odmChangeable/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1127,8 +1115,6 @@
</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
<odmChangeable/>
<persistRuntime/>
<initToZero/>
</attribute>
Expand Down Expand Up @@ -1162,7 +1148,6 @@
</description>
<valueType>uint64</valueType>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand Down Expand Up @@ -1193,7 +1178,6 @@
</enum>
<initToZero/>
<writeable/>
<persistRuntime/>
</attribute>

<!-- ********************************************************************** -->
Expand All @@ -1210,7 +1194,6 @@
<valueType>uint64</valueType>
<array>24</array>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand Down Expand Up @@ -1242,7 +1225,6 @@
<array>24</array>
<initToZero/>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1254,7 +1236,6 @@
</description>
<valueType>uint64</valueType>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand Down Expand Up @@ -1285,7 +1266,6 @@
</enum>
<initToZero/>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1301,6 +1281,7 @@
</enum>
<platInit/>
<initToZero/>
<mrwHide/><!-- Temporary until the function is actually ready -->
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1327,7 +1308,6 @@
</description>
<valueType>uint64</valueType>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand Down Expand Up @@ -1358,7 +1338,6 @@
</enum>
<initToZero/>
<writeable/>
<persistRuntime/>
</attribute>
<!-- ********************************************************************** -->
<attribute>
Expand All @@ -1373,7 +1352,6 @@
<valueType>uint64</valueType>
<array>8</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************** -->
Expand All @@ -1389,7 +1367,6 @@
<valueType>uint64</valueType>
<array>8</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************* -->
Expand All @@ -1405,7 +1382,6 @@
<valueType>uint64</valueType>
<array>4</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************* -->
Expand All @@ -1421,7 +1397,6 @@
<valueType>uint64</valueType>
<array>4</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ********************************************************************* -->
Expand All @@ -1438,7 +1413,6 @@
<valueType>uint8</valueType>
<array>8</array>
<writeable/>
<persistRuntime/>
<initToZero/>
</attribute>
<!-- ******************************************************************** -->
Expand Down

0 comments on commit c9b4851

Please sign in to comment.