Skip to content

Commit

Permalink
fapi2: Use correct RingMode type
Browse files Browse the repository at this point in the history
Some compilers will warn when using 0 as it does not have the correct
type. Instead use enum RingMode::RING_MODE_HEADER_CHECK which
corresponds to 0.

Change-Id: If1f6569297ce8a66755e08409c81f4649593ff6a
Signed-off-by: Joel Stanley <joel.stanley@au1.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67802
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67803
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
Joel Stanley authored and sgupta2m committed Nov 1, 2018
1 parent 9fcda53 commit d779bc1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/import/hwpf/fapi2/include/fapi2_hw_access.H
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ template< TargetType K, typename V >
inline ReturnCode getRing(const Target<K, V>& i_target,
const scanRingId_t i_address,
variable_buffer& o_data,
const RingMode i_ringMode = 0);
const RingMode i_ringMode = RING_MODE_HEADER_CHECK);

/// @brief Read-modify-write a ring on a chip.
/// @tparam K template parameter, passed in target.
Expand All @@ -190,7 +190,7 @@ inline ReturnCode modifyRing(const Target<K, V>& i_target,
const scanRingId_t i_address,
const variable_buffer& i_data,
const ChipOpModifyMode i_modifyMode,
const RingMode i_ringMode = 0);
const RingMode i_ringMode = RING_MODE_HEADER_CHECK);
#endif

// --------------------------------------------------------------------------
Expand Down

0 comments on commit d779bc1

Please sign in to comment.