Skip to content

Commit

Permalink
Fixes LRDIMM eff_config bugs
Browse files Browse the repository at this point in the history
Change-Id: I74dd2332bda79ab9578d450ba74322fd953b1f46
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67863
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69816
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Tested-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
sglancy6 authored and sgupta2m committed Dec 18, 2018
1 parent 88910ed commit f97b07d
Showing 1 changed file with 60 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2409,6 +2409,7 @@
<valueType>uint8</valueType>
<writeable />
<array> 2 2 </array>
<mssAccessorName>eff_dimm_ddr4_bc06</mssAccessorName>
</attribute>

<attribute>
Expand Down Expand Up @@ -2518,6 +2519,7 @@
<valueType>uint8</valueType>
<writeable />
<array> 2 2 </array>
<mssAccessorName>eff_dimm_ddr4_f0bc1x</mssAccessorName>
</attribute>

<attribute>
Expand Down Expand Up @@ -2568,6 +2570,7 @@
<valueType>uint8</valueType>
<writeable />
<array> 2 2 </array>
<mssAccessorName>eff_dimm_ddr4_f0bc6x</mssAccessorName>
</attribute>

<attribute>
Expand Down Expand Up @@ -2697,6 +2700,17 @@
<array> 2 2 </array>
</attribute>

<attribute>
<id>ATTR_EFF_DIMM_DDR4_F2BCEx</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>F2BCWEx Host Interface DFE Programming Control Word</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<writeable />
<array> 2 2 </array>
<mssAccessorName>eff_dimm_ddr4_f2bcex</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_DIMM_DDR4_F4BC0x</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down Expand Up @@ -2815,6 +2829,7 @@
<valueType>uint8</valueType>
<writeable />
<array> 2 2 </array>
<mssAccessorName>eff_dimm_ddr4_f5bc5x</mssAccessorName>
</attribute>

<attribute>
Expand Down Expand Up @@ -3003,6 +3018,51 @@
<mssAccessorName>eff_dram_tdqs</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_EFF_DRAM_ODIC</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>
DRAM output driver impedance control (ODIC)
</description>
<initToZero></initToZero>
<valueType>uint8</valueType>
<enum>OHM34 = 34, OHM48 = 48</enum>
<writeable/>
<array> 2 2 4 </array>
<mssAccessorName>eff_dram_odic</mssAccessorName>
</attribute>

<attribute>
<id>ATTR_MSS_EFF_ODT_RD</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>
READ, On Die Termination triggering bitmap. Use bitmap to determine which ODT to fire for the designated rank.
The bits in 8 bit field are [Dimm0 ODT0][Dimm0 ODT1][N/A][N/A][Dimm1 ODT0][Dimm1 ODT1][N/A][N/A]
Attribute is derived from VPD for RDIMM or from termination settings for LRDIMM
</description>
<initToZero></initToZero>
<writeable/>
<valueType>uint8</valueType>
<mssAccessorName>eff_odt_rd</mssAccessorName>
<array>2 2 4</array>
</attribute>

<attribute>
<id>ATTR_MSS_EFF_ODT_WR</id>
<targetType>TARGET_TYPE_MCS</targetType>
<description>
WRITE, On Die Termination triggering bitmap. Use bitmap to determine which ODT to fire for the designated rank.
The bits in 8 bit field are [Dimm0 ODT0][Dimm0 ODT1][N/A][N/A][Dimm1 ODT0][Dimm1 ODT1][N/A][N/A]
Attribute is derived from VPD for RDIMM or from termination settings for LRDIMM
</description>
<initToZero></initToZero>
<writeable/>
<valueType>uint8</valueType>
<writeable/>
<mssAccessorName>eff_odt_wr</mssAccessorName>
<array>2 2 4</array>
</attribute>

<attribute>
<id>ATTR_EFF_DRAM_TREFI</id>
<targetType>TARGET_TYPE_MCS</targetType>
Expand Down

0 comments on commit f97b07d

Please sign in to comment.