Skip to content

Commit

Permalink
code bug: single step was not restoring dbcr
Browse files Browse the repository at this point in the history
Change-Id: I8980432fb6bfa2c41e709a1a5a0c111a151753f7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31888
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48009
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
Ashish authored and sgupta2m committed Oct 5, 2017
1 parent c6adbaf commit fcf4e20
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/import/chips/p9/procedures/hwp/lib/p9_ppe_utils.C
Expand Up @@ -571,6 +571,7 @@ fapi2::ReturnCode ppe_single_step(
FAPI_DBG("Move i_Rs to SPRG0 : so now SPRG0 has DBCR value");
l_data64.flush<0>().insertFromRight(ppe_getMtsprInstruction(i_Rs, SPRG0), 0, 32);
FAPI_DBG("getMtsprInstruction(%d, SPRG0): 0x%16llX", i_Rs, l_data64 );
FAPI_TRY(fapi2::putScom(i_target, i_base_address + PPE_XIRAMEDR, l_data64));

FAPI_DBG("Save SPRG0 i.e. DBCR");
FAPI_TRY(getScom(i_target, i_base_address + PPE_XIRAMDBG, l_data64), "Error in GETSCOM");
Expand All @@ -590,7 +591,7 @@ fapi2::ReturnCode ppe_single_step(
FAPI_TRY(fapi2::putScom(i_target, i_base_address + PPE_XIRAMGA, l_data64 ));
FAPI_DBG("Restore SPRG0");
FAPI_TRY(ppe_pollHaltState(i_target, i_base_address));
FAPI_TRY(putScom(i_target, i_base_address + PPE_XIRAMDBG , l_sprg0_save), "Error in GETSCOM");
FAPI_TRY(putScom(i_target, i_base_address + PPE_XIRAMDBG , l_sprg0_save), "Error in PUTSCOM");

while(i_step_count != 0)
{
Expand Down

0 comments on commit fcf4e20

Please sign in to comment.