opal/hmi: Fix double unlock of hmi lock in failure path.

unlock once and goto error_out. Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
open-power · Mar 5, 2019 · 017da88 · 017da88
1 parent 52be9b8
commit 017da88
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/core/hmi.c b/core/hmi.c
@@ -1042,13 +1042,9 @@ static int handle_all_core_tfac_error(uint64_t tfmr, uint64_t *out_flags)
 			if (!recover_corrupt_tfmr()) {
 				unlock(&hmi_lock);
 				recover = 0;
+				goto error_out;
 			}
 
-		if (!recover) {
-			unlock(&hmi_lock);
-			goto error_out;
-		}
-
 		tfmr = mfspr(SPR_TFMR);
 
 		/* We could have got new thread errors in the meantime */