Skip to content

Commit

Permalink
phb4: Fix typo in disable lane eq code
Browse files Browse the repository at this point in the history
In this commit
  commit 737c0ba
  Author: Michael Neuling <mikey@neuling.org>
  Date:   Thu Feb 22 10:52:18 2018 +1100
  phb4: Disable lane eq when retrying some nvidia GEN3 devices

We made a typo and set PH2 twice. This fixes it.

It worked previously as if only phase 2 (PH2) is set it, skips phase 2
and phase 3 (PH3).

Reported-by: Meng Li <shlimeng@cn.ibm.com>
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
mikey authored and stewartsmith committed Sep 18, 2018
1 parent 801462f commit 051da83
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/phb4.c
Original file line number Diff line number Diff line change
Expand Up @@ -4876,7 +4876,7 @@ static void phb4_init_hw(struct phb4 *p)
/* Read modify write and set to 2 bits */
PHBDBG(p, "LINK: Disabling Lane EQ\n");
val = in_be64(p->regs + PHB_PCIE_DLP_CTL);
val |= PHB_PCIE_DLP_CTL_BYPASS_PH2 | PHB_PCIE_DLP_CTL_BYPASS_PH2;
val |= PHB_PCIE_DLP_CTL_BYPASS_PH2 | PHB_PCIE_DLP_CTL_BYPASS_PH3;
out_be64(p->regs + PHB_PCIE_DLP_CTL, val);
}

Expand Down

0 comments on commit 051da83

Please sign in to comment.