Skip to content

Commit

Permalink
core/pci: Increase the max slot string size
Browse files Browse the repository at this point in the history
The maximum string length for the slot label / device location code in
the PCI summary is currently 32 characters. This results in some IBM
location codes being truncated due to their length, e.g.

PHB#0001:02:11.0 [SWDN]  SLOT=C11  x8
PHB#0001:13:00.0 [EP  ] *snip* LOC_CODE=U78D3.ND1.WZS004A-P1-C
PHB#0001:13:00.1 [EP  ] *snip* LOC_CODE=U78D3.ND1.WZS004A-P1-C
PHB#0001:13:00.2 [EP  ] *snip* LOC_CODE=U78D3.ND1.WZS004A-P1-C
PHB#0001:13:00.3 [EP  ] *snip* LOC_CODE=U78D3.ND1.WZS004A-P1-C

Which obscure the actual location of the card, and it looks bad. This
patch increases the maximum length of the label string to 80 characters
since that's the maximum length for a location code.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
oohal authored and stewartsmith committed Mar 28, 2019
1 parent 0ec1e37 commit 14372fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1471,7 +1471,7 @@ static void pci_print_summary_line(struct phb *phb, struct pci_device *pd,
{
const char *label, *dtype, *s;
u32 vdid;
#define MAX_SLOTSTR 32
#define MAX_SLOTSTR 80
char slotstr[MAX_SLOTSTR + 1] = { 0, };

pci_cfg_read32(phb, pd->bdfn, 0, &vdid);
Expand Down

0 comments on commit 14372fc

Please sign in to comment.