Skip to content

Commit

Permalink
cpufeatures: Always advertise POWER8NVL as DD2
Browse files Browse the repository at this point in the history
Despite the major version of PVR being 1 (0x004c0100) for POWER8NVL,
these chips are functionally equalent to P8/P8E DD2 levels.

This advertises POWER8NVL as DD2. As the result, skiboot adds
ibm,powerpc-cpu-features/processor-control-facility for such CPUs and
the linux kernel can use hypervisor doorbell messages to wake secondary
threads; otherwise "KVM: CPU %d seems to be stuck" would appear because
of missing LPCR_PECEDH.

Fixes: 7f4c8e8 "dt: add /cpus/ibm, powerpc-cpu-features device tree bindings"
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
aik authored and stewartsmith committed Feb 11, 2019
1 parent 67fc150 commit 17975a6
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions core/cpufeatures.c
Original file line number Diff line number Diff line change
Expand Up @@ -885,16 +885,17 @@ void dt_add_cpufeatures(struct dt_node *root)
if (!cpu_name)
cpu_name = "POWER8E";
/* fallthrough */
case PVR_TYPE_P8NVL:
if (!cpu_name)
cpu_name = "POWER8NVL";

cpu_feature_isa = ISA_V2_07B;
if (PVR_VERS_MAJ(version) == 1)
cpu_feature_cpu = CPU_P8_DD1;
else
cpu_feature_cpu = CPU_P8_DD2;
break;
case PVR_TYPE_P8NVL:
cpu_name = "POWER8NVL";
cpu_feature_isa = ISA_V2_07B;
cpu_feature_cpu = CPU_P8_DD2;
break;
case PVR_TYPE_P9:
if (!cpu_name)
cpu_name = "POWER9";
Expand Down

0 comments on commit 17975a6

Please sign in to comment.