Skip to content

Commit

Permalink
ipmi: Reduce ipmi_queue_msg_sync() polling loop time to 10ms
Browse files Browse the repository at this point in the history
On a plain boot, this reduces the time spent in OPAL by ~170ms on
p9dsu. This is due to hiomap (currently) using synchronous IPMI
messages.

It will also *significantly* reduce latency on runtime flash
operations, as we'll spend typically 10-20ms in OPAL rather than
100-200ms. It's not an ideal solution to that, but it's a quick
and obvious win for jitter.

Cc: stable
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
stewartsmith committed Nov 19, 2018
1 parent cdaa6d1 commit 28bf1fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/ipmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ void ipmi_queue_msg_sync(struct ipmi_msg *msg)
unlock(&sync_lock);

while (sync_msg == msg)
time_wait_ms(100);
time_wait_ms(10);
}

static void ipmi_read_event_complete(struct ipmi_msg *msg)
Expand Down

0 comments on commit 28bf1fa

Please sign in to comment.