Skip to content

Commit

Permalink
hw/fsp: Remove stray va_end() in __fsp_fillmsg()
Browse files Browse the repository at this point in the history
__fsp_fillmsg() is called from fsp_fillmsg() and fsp_mkmsg(). Both
callers wrap it in a va_start() / va_end() pair so using va_end()
inside the function is almost certainly wrong.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
oohal committed Mar 11, 2020
1 parent daf9215 commit 2e122fb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/fsp/fsp.c
Expand Up @@ -995,7 +995,6 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod,

for (i = 0; i < add_words; i++)
fsp_msg_set_data_word(msg, i, va_arg(list, unsigned int));
va_end(list);
}

void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u32 add_words, ...)
Expand Down

0 comments on commit 2e122fb

Please sign in to comment.