Skip to content

Commit

Permalink
sparse: symbol '*bar*' was not declared. Should it be static?
Browse files Browse the repository at this point in the history
Yes, a bunch of HOMER symbols should be.

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
stewartsmith committed Feb 26, 2019
1 parent 039d184 commit 3b8b7e8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hw/homer.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright 2013-2014 IBM Corp.
/* Copyright 2013-2019 IBM Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -44,8 +44,8 @@ enum P9_BAR {
P9_BAR_SBE = 3,
};

u64 pba_bar0, pba_barmask0;
u8 bar_homer, bar_slw, bar_occ_common;
static u64 pba_bar0, pba_barmask0;
static u8 bar_homer, bar_slw, bar_occ_common;

static bool read_pba_bar(struct proc_chip *chip, unsigned int bar_no,
uint64_t *base, uint64_t *size)
Expand Down

0 comments on commit 3b8b7e8

Please sign in to comment.