Skip to content

Commit

Permalink
core/pci-quirk: Remove broken comment in quirk_astbmc_vga()
Browse files Browse the repository at this point in the history
The comment talks about one mechanism to handle the quirk whilst the
code uses another. Avoid confusion by removing the comment.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
amboar authored and stewartsmith committed Jul 17, 2018
1 parent 5b1bc2f commit 467b00f
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions core/pci-quirk.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,6 @@ static void quirk_astbmc_vga(struct phb *phb __unused,
struct dt_node *np = pd->dn;
uint32_t revision, mcr_configuration, mcr_scu_mpll, mcr_scu_strap;

/*
* These accesses will only work if the BMC address 0x1E6E2180 is set
* to 0x7B, which is its default state on current systems. In future,
* for security purposes it is proposed to configure this register to
* disallow accesses from the host, and provide the properties that
* the Linux ast VGA driver used through the device tree instead.
* Here we set those properties so we can test how things would work
* if the window into BMC memory was closed.
*
* If both the petitboot kernel and the host kernel have an ast driver
* that reads properties from the device tree, setting 0x1E6E2180 to
* 0x79 will disable the backdoor into BMC memory and the only way the
* ast driver can operate is using the device tree properties.
*/

revision = ast_ahb_readl(SCU_REVISION_ID);
mcr_configuration = ast_ahb_readl(MCR_CONFIGURATION);
mcr_scu_mpll = ast_ahb_readl(MCR_SCU_MPLL);
Expand Down

0 comments on commit 467b00f

Please sign in to comment.