Skip to content

Commit

Permalink
libflash/ipmi-hiomap: Remove unused close handling
Browse files Browse the repository at this point in the history
[ Upstream commit 6d8bd2d ]

Issuing a HIOMAP_C_CLOSE is not required by the protocol specification,
rather a close can be implicit in a subsequent
CREATE_{READ,WRITE}_WINDOW request. The implicit close provides an
opportunity to reduce LPC traffic and the implementation takes up that
optimisation, so remove the case from the IPMI callback handler.

Cc: stable
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
  • Loading branch information
amboar authored and Vasant Hegde committed Mar 4, 2019
1 parent 0576b74 commit 5117b2c
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions libflash/ipmi-hiomap.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,6 @@ static void ipmi_hiomap_cmd_cb(struct ipmi_msg *msg)

break;
}
case HIOMAP_C_CLOSE_WINDOW:
lock(&ctx->lock);
ctx->window_state = closed_window;
unlock(&ctx->lock);
break;
case HIOMAP_C_MARK_DIRTY:
case HIOMAP_C_FLUSH:
case HIOMAP_C_ACK:
Expand Down

0 comments on commit 5117b2c

Please sign in to comment.