Skip to content

Commit

Permalink
Silence sparse warning for version.c
Browse files Browse the repository at this point in the history
version.c:1:12: warning: symbol 'version' was not declared. Should it be static?

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
stewartsmith authored and oohal committed Jul 19, 2019
1 parent 9570730 commit 648c7cf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions Makefile.main
Expand Up @@ -303,6 +303,7 @@ version.c: $(SRC)/make_version.sh $(OBJS_NO_VER) .version
@(if [ "a$(VERSION)" = "a" ]; then \
echo "#error You need to set SKIBOOT_VERSION environment variable" > $@ ;\
else \
echo "extern const char version[];"; \
echo "const char version[] = \"$(VERSION)\";" ;\
fi) > $@

Expand Down
1 change: 1 addition & 0 deletions core/init.c
Expand Up @@ -57,6 +57,7 @@
enum proc_gen proc_gen;
unsigned int pcie_max_link_speed;
bool verbose_eeh;
extern const char version[];

static uint64_t kernel_entry;
static size_t kernel_size;
Expand Down

0 comments on commit 648c7cf

Please sign in to comment.