Skip to content

Commit

Permalink
hmi: Fix clearing HMER on debug trigger
Browse files Browse the repository at this point in the history
In the recent patch:
  eddff9b hmi: Clear unknown debug trigger

I rebased the code from an older skiboot before the HMI rework. When I
did this, I missed the handled flag. Without this the HMER is not
cleared properly and the HMI keeps happening.

This properly sets the handled flag and hence clears the HMER bit.

Signed-off-by: Michael Neuling <mikey@neuling.org>
Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
mikey authored and stewartsmith committed May 9, 2018
1 parent 6449e2a commit 6790a94
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions core/hmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,7 @@ static int handle_hmi_exception(uint64_t hmer, struct OpalHMIEvent *hmi_evt,
}
}
if (hmer & SPR_HMER_TRIG_FIR_HMI) {
handled |= SPR_HMER_TRIG_FIR_HMI;
hmer &= ~SPR_HMER_TRIG_FIR_HMI;

hmi_print_debug("Clearing unknown debug trigger", hmer);
Expand Down

0 comments on commit 6790a94

Please sign in to comment.