Skip to content

Commit

Permalink
platforms/witherspoon: Make PCIe shared slot error message more infor…
Browse files Browse the repository at this point in the history
…mative

If we're missing chips for some reason, we print a warning when configuring
the PCIe shared slot.

The warning doesn't really make it clear what "shared slot" is, and if it's
printed, it'll come right after a bunch of messages about NPU setup, so
let's clarify the message to explicitly mention PCI.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
[stewart: bikeshed]
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
ajdlinux authored and stewartsmith committed Feb 19, 2019
1 parent 9636295 commit 682fa68
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions platforms/astbmc/witherspoon.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright 2017 IBM Corp.
/* Copyright 2017-2019 IBM Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -184,7 +184,8 @@ static void witherspoon_shared_slot_fixup(void)
chip1 = next_chip(chip0);
if (!chip1 || next_chip(chip1)) {
prlog(PR_WARNING,
"Unexpected number of chips, skipping shared slot detection\n");
"PLAT: Can't find second chip, "
"skipping PCIe shared slot detection\n");
return;
}

Expand Down

0 comments on commit 682fa68

Please sign in to comment.