Skip to content

Commit

Permalink
test-ipmi-hiomap: Add read-one-byte test
Browse files Browse the repository at this point in the history
Add test case to read:
  - 1 byte
  - 1 block and 1 byte data

Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: skiboot-stable@lists.ozlabs.org
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
Vasant Hegde authored and stewartsmith committed Apr 9, 2019
1 parent 9fd1495 commit 857f046
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions libflash/test/test-ipmi-hiomap.c
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,24 @@ static void test_hiomap_protocol_read_one_block(void)
scenario_exit();
}

static void test_hiomap_protocol_read_one_byte(void)
{
struct blocklevel_device *bl;
uint8_t *buf;
size_t len;

scenario_enter(scenario_hiomap_protocol_read_one_block);
assert(!ipmi_hiomap_init(&bl));
len = 1;
buf = calloc(1, len);
assert(buf);
assert(!bl->read(bl, 0, buf, len));
assert(lpc_read_success(buf, len));
free(buf);
ipmi_hiomap_exit(bl);
scenario_exit();
}

static const struct scenario_event
scenario_hiomap_protocol_read_two_blocks[] = {
{ .type = scenario_event_p, .p = &hiomap_ack_call, },
Expand Down Expand Up @@ -929,6 +947,26 @@ static void test_hiomap_protocol_read_two_blocks(void)
scenario_exit();
}

static void test_hiomap_protocol_read_1block_1byte(void)
{
struct blocklevel_device *bl;
struct ipmi_hiomap *ctx;
uint8_t *buf;
size_t len;

scenario_enter(scenario_hiomap_protocol_read_two_blocks);
assert(!ipmi_hiomap_init(&bl));
ctx = container_of(bl, struct ipmi_hiomap, bl);
len = (1 << ctx->block_size_shift) + 1;
buf = calloc(1, len);
assert(buf);
assert(!bl->read(bl, 0, buf, len));
assert(lpc_read_success(buf, len));
free(buf);
ipmi_hiomap_exit(bl);
scenario_exit();
}

static const struct scenario_event
scenario_hiomap_protocol_read_one_block_twice[] = {
{ .type = scenario_event_p, .p = &hiomap_ack_call, },
Expand Down Expand Up @@ -3112,7 +3150,9 @@ struct test_case test_cases[] = {
TEST_CASE(test_hiomap_event_daemon_regained_flash_control_dirty),
TEST_CASE(test_hiomap_protocol_reset_recovery),
TEST_CASE(test_hiomap_protocol_read_one_block),
TEST_CASE(test_hiomap_protocol_read_one_byte),
TEST_CASE(test_hiomap_protocol_read_two_blocks),
TEST_CASE(test_hiomap_protocol_read_1block_1byte),
TEST_CASE(test_hiomap_protocol_read_one_block_twice),
TEST_CASE(test_hiomap_protocol_event_before_read),
TEST_CASE(test_hiomap_protocol_event_during_read),
Expand Down

0 comments on commit 857f046

Please sign in to comment.