Skip to content

Commit

Permalink
FSP: Improve Reset/Reload log message
Browse files Browse the repository at this point in the history
Below message is confusing. Lets make it clear.

FSP sends "R/R complete notification" whenever there is a dump. We use `flag`
to identify whether its its R/R completion -OR- just new dump notification.

[  483.406351956,6] FSP: SP says Reset/Reload complete
[  483.406354278,5] DUMP: FipS dump available. ID = 0x1a00001f [size: 6367640 bytes]
[  483.406355968,7]   A Reset/Reload was NOT done

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
Vasant Hegde authored and stewartsmith committed Sep 20, 2018
1 parent 832cac1 commit 904623d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions hw/fsp/fsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,6 @@ static bool fsp_local_command(u32 cmd_sub_mod, struct fsp_msg *msg)
fsp_alloc_inbound(msg);
return true;
case FSP_CMD_SP_RELOAD_COMP:
prlog(PR_INFO, "FSP: SP says Reset/Reload complete\n");
if (msg->data.bytes[3] & PPC_BIT8(0)) {
fsp_fips_dump_notify(msg->data.words[1],
msg->data.words[2]);
Expand All @@ -1309,8 +1308,9 @@ static bool fsp_local_command(u32 cmd_sub_mod, struct fsp_msg *msg)
msg->data.words[3]);
}
if (msg->data.bytes[3] & PPC_BIT8(2)) {
prlog(PR_DEBUG, " A Reset/Reload was NOT done\n");
prlog(PR_INFO, "FSP: SP Reset/Reload was NOT done\n");
} else {
prlog(PR_INFO, "FSP: SP says Reset/Reload complete\n");
/* Notify clients that the FSP is back up */
fsp_notify_rr_state(FSP_RELOAD_COMPLETE);
fsp_repost_queued_msgs_post_rr();
Expand Down

0 comments on commit 904623d

Please sign in to comment.