Skip to content

Commit

Permalink
platforms/swift: Remove spurious error message
Browse files Browse the repository at this point in the history
npu3_chip_possible_gpus() works by dividing the number of NVLink-mode
bricks by the number of bricks connecting a single GPU. In a system with
no GPUs, the latter value is unknown, so the function returns zero and
we trip a somewhat misleading error message.

The code afterward is safe to execute in any case, so there's no need to
return either. Remove the check entirely.

Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
rarbab authored and oohal committed Nov 3, 2019
1 parent 66ab3cb commit 91b4be5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions platforms/astbmc/swift.c
Expand Up @@ -63,11 +63,6 @@ static void swift_finalise_dt(bool is_reboot)
if (is_reboot)
return;

if (npu3_chip_possible_gpus() != 2) {
prlog(PR_ERR, "NPU: Unknown link topology detected\n");
return;
}

/* Collect the first link we find for each GPU */
npu3_for_each_nvlink_npu(npu) {
npu3_for_each_nvlink_dev(dev, npu) {
Expand Down

0 comments on commit 91b4be5

Please sign in to comment.