Skip to content

Commit

Permalink
core/platform: Actually disable fast-reboot on P8
Browse files Browse the repository at this point in the history
There was an attempt. It was not successful.

Fixes: 14f709b ("Disable fast-reset for POWER8")
Cc: skiboot-stable@lists.ozlabs.org
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
oohal committed Oct 2, 2019
1 parent 7066a9c commit 923b5a5
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions core/platform.c
Expand Up @@ -54,13 +54,15 @@ static int64_t opal_cec_reboot(void)

opal_quiesce(QUIESCE_HOLD, -1);

if (proc_gen == proc_gen_p8 && nvram_query_eq_safe("fast-reset","1")) {
if (proc_gen == proc_gen_p8) {
/*
* Bugs in P8 mean fast reboot isn't 100% reliable when cores
* are busy, so only attempt if explicitly *enabled*.
*/
fast_reboot();
} else if (!nvram_query_eq_safe("fast-reset","0")) {
if (nvram_query_eq_safe("fast-reset", "1"))
fast_reboot();

} else if (!nvram_query_eq_safe("fast-reset", "0")) {
/* Try fast-reset unless explicitly disabled */
fast_reboot();
}
Expand Down

0 comments on commit 923b5a5

Please sign in to comment.