Skip to content

Commit

Permalink
npu: Fix device binding error message
Browse files Browse the repository at this point in the history
Helping someone troubleshoot a Garrison machine, I noticed some of the
BDFs printed here are wrong:

npu_dev_bind_pci_dev: No PCI device for NPU device 0004:00:00.0 to bind to. If you expect a GPU to be there, this is a problem.
npu_dev_bind_pci_dev: No PCI device for NPU device 0004:00:01.0 to bind to. If you expect a GPU to be there, this is a problem.
npu_dev_bind_pci_dev: No PCI device for NPU device 0004:00:04.0 to bind to. If you expect a GPU to be there, this is a problem.
npu_dev_bind_pci_dev: No PCI device for NPU device 0004:00:05.0 to bind to. If you expect a GPU to be there, this is a problem.

Change the prlog() call to print them correctly.

Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
rarbab authored and oohal committed Aug 16, 2019
1 parent 2422c10 commit a36a494
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions hw/npu.c
Expand Up @@ -385,8 +385,12 @@ static void npu_dev_bind_pci_dev(struct npu_dev *dev)
}
}

prlog(PR_INFO, "%s: No PCI device for NPU device %04x:00:%02x.0 to bind to. If you expect a GPU to be there, this is a problem.\n",
__func__, dev->npu->phb.opal_id, dev->index);
prlog(PR_INFO, "%s: No PCI device for NPU device %04x:%02x:%02x.%x to bind to. If you expect a GPU to be there, this is a problem.\n",
__func__, dev->npu->phb.opal_id,
dev->pvd->bdfn >> 8 & 0xff,
dev->pvd->bdfn >> 3 & 0x1f,
dev->pvd->bdfn & 0x7);

}

static struct lock pci_npu_phandle_lock = LOCK_UNLOCKED;
Expand Down

0 comments on commit a36a494

Please sign in to comment.