Skip to content

Commit

Permalink
p9dsu: Undo slot label name changes
Browse files Browse the repository at this point in the history 
During some code updates the slot labels were updated to reflect
the phb layout, however expectations were that the slot labels be
aligned with the riser card slots and not the system planar slots.

[stewart: The tale of how we got here is long and varied and not at
all clear. The first ESS systems went out with a skiboot v5.9.8 with
additional SuperMicro patches. It was probably a slot table, but who knows,
we don't have the code so can't check. It's possible it was all coming
in through HDAT instead). The op-build tree (thus the exact patches)
shipped on systems that work correct seems to not be around anywhere anymore
(if it ever was). It was only in skiboot v6.0 that a slot table made
it in, and, of course, only having remote machines in random configs,
including possibly with riser cards from Briggs&Stratton rather than
the ones destined for this system, doesn't make for verifying this
at all. It also doesn't help that *consistently* there is *never*
any review on slot tables, and we've had things be wrong in the past.
Combine this with not upstream Hostboot patches.]

Cc: skiboot-stable@lists.ozlabs.org
Cc: Benjamin Mashak <mashak@us.ibm.com>
Cc: Michael Lim <youhour@us.ibm.com>
Fixes: 64a16ae ("p9dsu: Fix slot labels for p9dsu2u")
Fixes: 87517c8 ("p9dsu: Fix p9dsu slot tables")
Fixes: 31231ed ("p9dsu: Fix p9dsu default variant")
Signed-off-by: Deb McLemore <debmc@linux.ibm.com>
[stewart: added more detailed explanation, cc stable]
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
@debmc @stewartsmith
debmc authored and stewartsmith committed Mar 15, 2019
1 parent 7cd8402 commit c470806
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions platforms/astbmc/p9dsu.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ static const struct slot_table_entry p9dsu1u_phb8_1_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO-R Slot2",
.name = "WIO-R Slot",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -120,7 +120,7 @@ static const struct slot_table_entry p9dsu1u_phb8_3_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO Slot4",
.name = "WIO Slot2",
.power_limit = 75,
},
{ .etype = st_end },
Expand Down Expand Up @@ -251,7 +251,7 @@ static const struct slot_table_entry p9dsu2u_phb8_1_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO-R Slot2",
.name = "WIO-R Slot",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -271,7 +271,7 @@ static const struct slot_table_entry p9dsu2u_phb8_3_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO Slot4",
.name = "WIO Slot3",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -281,7 +281,7 @@ static const struct slot_table_entry p9dsu2u_phb8_4_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO Slot5",
.name = "WIO Slot2",
.power_limit = 75,
},
{ .etype = st_end },
Expand Down Expand Up @@ -357,13 +357,13 @@ static const struct slot_table_entry p9dsu2uess_uio_plx_down[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0x8,0),
.name = "PLX SWITCH UIO Slot2",
.name = "PLX switch",
.power_limit = 75,
},
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0x9,0),
.name = "PLX DOWN LAN UIO Slot2",
.name = "Onboard LAN",
},
{ .etype = st_end },
};
Expand All @@ -373,7 +373,7 @@ static const struct slot_table_entry p9dsu2uess_uio_plx_up[] = {
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.children = p9dsu2uess_uio_plx_down,
.name = "PLX UP UIO Slot2",
.name = "PLX up",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -383,19 +383,19 @@ static const struct slot_table_entry p9dsu2uess_wio_plx_down[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0x1,0),
.name = "WIO Slot3",
.name = "WIO Slot1",
.power_limit = 75,
},
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0x8,0),
.name = "PLX SWITCH WIO Slot3",
.name = "PLX switch",
.power_limit = 75,
},
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0x9,0),
.name = "WIO Slot3",
.name = "WIO Slot2",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -406,7 +406,7 @@ static const struct slot_table_entry p9dsu2uess_wio_plx_up[] = {
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.children = p9dsu2uess_wio_plx_down,
.name = "PLX UP WIO Slot3",
.name = "PLX up",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -427,7 +427,7 @@ static const struct slot_table_entry p9dsu2uess_phb0_1_slot[] = {
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.children = p9dsu2uess_uio_plx_up,
.name = "PLX UIO Slot2",
.name = "PLX",
.power_limit = 75,
},
{ .etype = st_end },
Expand Down Expand Up @@ -474,7 +474,7 @@ static const struct slot_table_entry p9dsu2uess_phb8_0_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO Slot1",
.name = "WIO Slot3",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -484,7 +484,7 @@ static const struct slot_table_entry p9dsu2uess_phb8_1_slot[] = {
{
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.name = "WIO-R Slot2",
.name = "WIO-R Slot",
.power_limit = 75,
},
{ .etype = st_end },
Expand All @@ -495,7 +495,7 @@ static const struct slot_table_entry p9dsu2uess_phb8_2_slot[] = {
.etype = st_pluggable_slot,
.location = ST_LOC_DEVFN(0,0),
.children = p9dsu2uess_wio_plx_up,
.name = "PLX WIO Slot3",
.name = "PLX",
.power_limit = 75,
},
{ .etype = st_end },
Expand Down

0 comments on commit c470806

Please sign in to comment.