Skip to content

Commit

Permalink
nvram: Fix wait-for-nvram message
Browse files Browse the repository at this point in the history
We print a message when nvram_query() needs to wait for the NVRAM to
be loaded from the BMC/FSP. Currently this is printed at PR_WARNING
which is excessive since this doesn't actually indicate that anything is
wrong. There's also nothing that we can really do about loading the
NVRAM being slow, so just print this at PR_DEBUG.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
oohal authored and stewartsmith committed Sep 18, 2018
1 parent 7665748 commit c94de02
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions core/nvram-format.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ const char *nvram_query(const char *key)
assert(key);

if (!nvram_has_loaded()) {
prlog(PR_WARNING, "NVRAM: Query before is done loading\n");
prlog(PR_WARNING, "NVRAM: Waiting for load\n");
prlog(PR_DEBUG,
"NVRAM: Query for '%s' must wait for NVRAM to load\n",
key);
if (!nvram_wait_for_load()) {
prlog(PR_CRIT, "NVRAM: Failed to load\n");
return NULL;
Expand Down

0 comments on commit c94de02

Please sign in to comment.